HBASE-22338 LICENSE file only contains Apache 2.0 #93
Conversation
- fix NOTICE.aggregate generation
|
🎊 +1 overall
This message was automatically generated. |
busbey
left a comment
busbey
left a comment
There was a problem hiding this comment.
Do you have examples of the generated LICENSE/NOTIC files after this change?
I'll build locally in the mean time to get them.
pom.xml
Outdated
| <java.min.version>${compileSource}</java.min.version> | ||
| <!-- override on command line to have generated LICENSE files include | ||
| diagnostic info for verifying notice requirements --> | ||
| <build.year>2022</build.year> |
There was a problem hiding this comment.
we set this already via the buildnumber-maven-plugin. is that not working?
There was a problem hiding this comment.
during my test, I don't know why it's not working, here is the output https://issues.apache.org/jira/secure/attachment/13040127/NOTICE.aggregate-no-build-year (I did check the hbase code, seems very similar just not working)
Apache HBase Connectors - Assembly
Copyright 2018-${copyright-end-year} The Apache Software Foundation
let me continue to check it.
There was a problem hiding this comment.
I can't the reason -.- although I tried to use -Dbuild.year=2022 and it worked.... I will revert the change for this build.year first. let me know if you find any thing. my goal is to have the dependency included in the NOTICE file correctly.
In addition, I'm wondered if we need to add a generated NOTICE for modules of spark e.g. hbase-spark?
There was a problem hiding this comment.
In addition, I'm wondered if we need to add a generated NOTICE for modules of spark e.g. hbase-spark
every artifact we create needs to have a proper LICENSE and NOTICE file. for the most part that should happen automatically for us unless we incorporate third party works in either the source or binary of an artifact.
sorry for the lag, let me look again at what the current artifacts look like with this change in place.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Here's what I see when verifying things. Starting with the branch for this PR: |
busbey
left a comment
busbey
left a comment
There was a problem hiding this comment.
I don't think this currently solves the issue with the generated assembly tarball
|
sorry, I'm learning toward this JIRA as well, what you mean here is that we need a NOTICE.txt/NOTICE after unzipping the tar ball. basically, I knew that the NOTICE file were generated at but for the LICENSE file, I may need another look. |
|
yup, you're right, I missed that file copy in the assembly tar, I checked it but please double check as well |
|
🎊 +1 overall
This message was automatically generated. |
|
we're missing the part of the main project tooling that checks for problems with the generated license: stax-api is dual licensed GPL and CDDL. We'll also need to specify that we're picking CDDL. The generated NOTICE is missing the build year: It looks like this is because we need to activate the |
|
nvm, I found the solution.... |
|
🎊 +1 overall
This message was automatically generated. |
|
@busbey I was out last weekend, sorry for the delay, but can you help to check again, I should have fixed what you commented. |
busbey
left a comment
busbey
left a comment
There was a problem hiding this comment.
The generated files look correct. But we still need to make sure the build will fail if we add some new dependency that is under a category-x license.
this enforcer check is what does it in the main project: https://github.com/apache/hbase/blob/rel/3.0.0-alpha-2/pom.xml#L1316
|
add the goal of |
|
🎊 +1 overall
This message was automatically generated. |
|
checking again, @busbey do you see if there is any other problem ? |
3 participants
please see the other discussion on #41 , and I think #41 should be closed and continue the discussion here.