Skip to content

Conversation

@rabi-kumar
Copy link
Contributor

Added license and notice files in each of the sub-module.

@asf-ci
Copy link

asf-ci commented Sep 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build/66/

----
This product includes ParaNamer Core Module version 2.3
under the terms of the BSD license which can be found at:
https://github.com/paul-hammant/paranamer/blob/master/LICENSE.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better if we could link to a REF, or atleast tag specific to the release version

other than Apache Software License Version 2. See LICENSE for full details

----
This product includes the SLF4J API Module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these things that end up in the jar file for hbase-kafka-model? it doesn't seem like we should.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the dependency file of hbase-kafka-model in targe/META-INF/DEPENDENCY SLF4J API Module was present there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that file just tells some tools that look at the jar what dependencies are needed at runtime. It doesn't mean we're packaging and distributing them.

a given LICENSE/NOTICE set of files should only cover the artifact they're found in. So each of these module should have a src/main/appended-resources/META-INF/LICENSE/NOTICE based on the contents of the jar that will be made by that module.

the only case where these would include dependencies is if we are making a "fat jar" or using the maven shade plugin to package our dependency into the jar.

I think that means for the connectors repo, it's only the convenience binary tarball that needs the aggregate information about our dependencies.

@asf-ci
Copy link

asf-ci commented Sep 12, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build/67/

@rabi-kumar
Copy link
Contributor Author

@busbey I have made the necessary changes as suggested above. Please let me know if there still are changes that need to be made.

----
This product includes ParaNamer Core Module version 2.3
under the terms of the BSD license which can be found at:
https://github.com/paul-hammant/paranamer/releases/tag/paranamer-2.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than Apache Software License Version 2. See LICENSE for full details

----
This product includes the SLF4J API Module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that file just tells some tools that look at the jar what dependencies are needed at runtime. It doesn't mean we're packaging and distributing them.

a given LICENSE/NOTICE set of files should only cover the artifact they're found in. So each of these module should have a src/main/appended-resources/META-INF/LICENSE/NOTICE based on the contents of the jar that will be made by that module.

the only case where these would include dependencies is if we are making a "fat jar" or using the maven shade plugin to package our dependency into the jar.

I think that means for the connectors repo, it's only the convenience binary tarball that needs the aggregate information about our dependencies.


----
This product includes following under
The Apache Software License, Version 2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things under the ALv2 license don't need have the license repeated here. I think the mention that we're distributing them under ALv2 should be in the NOTICE file.

@asf-ci
Copy link

asf-ci commented Sep 13, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build/68/

@rabi-kumar
Copy link
Contributor Author

Thank you for the detailed explanation @busbey . If there are issues and changes required then please do let me know.

@busbey
Copy link
Contributor

busbey commented Sep 13, 2019

This conversation on which LICENSE/NOTICE files need to change is still an issue AFAICT

#41 (comment)

I did a quick glance at our pom files and I don't think we're including these dependencies in any of our generated jar files.

So I think the only place that should have these changes is the connectors assembly module since it controls what goes into our convenience tarball.

@rabi-kumar
Copy link
Contributor Author

@busbey If that is the case then I can aggregate these and add them in assembly module but in hbase-connectors-assembly aggregated notice and license files are auto-generated in target/META-INF/maven-shared-archive-resources. So I don't know if it's necessary to add them but please do let me know if it's needed.

@busbey
Copy link
Contributor

busbey commented Sep 16, 2019

yes I believe the assembly module is the only place we need to have this information.

the stuff that's getting autogenerated right now is the implementation based on the main repo that I mentioned earlier. you can turn it off by removing the plugins that drive the executions aggregate-licenses and concat-NOTICE-files.

…notice files in assembly, removed plugins aggregating license and notice files for hbase repo in assembly pom
@asf-ci
Copy link

asf-ci commented Sep 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build/69/

@rabi-kumar
Copy link
Contributor Author

@busbey I have added the aggregated license and notice files in assembly module under src/main/resources and removed the plugins from assembly module which generated aggregated license and notice files for hbase-repo. Please do have a look at them in case if any changes are to be made.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 43s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 2m 8s master passed
+1 💚 compile 0m 10s master passed
+1 💚 javadoc 0m 9s master passed
-0 ⚠️ patch 0m 16s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 27s the patch passed
+1 💚 compile 0m 8s the patch passed
+1 💚 javac 0m 8s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
-1 ❌ whitespace 0m 0s The patch 2 line(s) with tabs.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 7s the patch passed
_ Other Tests _
+1 💚 unit 0m 9s hbase-connectors-assembly in the patch passed.
5m 20s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #41
Optional Tests dupname javac javadoc unit xml compile shellcheck shelldocs
uname Linux 820c63e4b757 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / d3175ad
Default Java Oracle Corporation-1.8.0_265-b01
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/whitespace-tabs.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/testReport/
Max. process+thread count 76 (vs. ulimit of 12500)
modules C: hbase-connectors-assembly U: hbase-connectors-assembly
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@meszibalu
Copy link
Contributor

@busbey @ravowlga123 do we need something for this change or can I merge it?

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 1m 33s master passed
+1 💚 compile 0m 5s master passed
+1 💚 javadoc 0m 6s master passed
-0 ⚠️ patch 0m 10s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 44s the patch passed
+1 💚 compile 0m 6s the patch passed
+1 💚 javac 0m 6s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
-1 ❌ whitespace 0m 0s The patch 2 line(s) with tabs.
+1 💚 xml 0m 0s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 5s the patch passed
_ Other Tests _
+1 💚 unit 0m 6s hbase-connectors-assembly in the patch passed.
4m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #41
Optional Tests dupname javac javadoc unit xml compile shellcheck shelldocs
uname Linux 402af93e39fb 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 4c46a24
Default Java Oracle Corporation-1.8.0_282-b08
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/whitespace-tabs.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/testReport/
Max. process+thread count 42 (vs. ulimit of 12500)
modules C: hbase-connectors-assembly U: hbase-connectors-assembly
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 2m 11s master passed
+1 💚 compile 0m 8s master passed
+1 💚 javadoc 0m 8s master passed
-0 ⚠️ patch 0m 11s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 4s the patch passed
+1 💚 compile 0m 6s the patch passed
+1 💚 javac 0m 6s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
-1 ❌ whitespace 0m 0s The patch 2 line(s) with tabs.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 6s the patch passed
_ Other Tests _
+1 💚 unit 0m 7s hbase-connectors-assembly in the patch passed.
5m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #41
Optional Tests dupname javac javadoc unit xml compile shellcheck shelldocs
uname Linux af1e070018d9 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 9a839b2
Default Java Oracle Corporation-1.8.0_282-b08
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/whitespace-tabs.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/testReport/
Max. process+thread count 42 (vs. ulimit of 12500)
modules C: hbase-connectors-assembly U: hbase-connectors-assembly
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@taklwu
Copy link
Contributor

taklwu commented Dec 9, 2021

will this block 1.0.1 release ? if so, I (or @rabi-kumar if he is still around) may pick this up.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 1m 57s master passed
+1 💚 compile 0m 6s master passed
+1 💚 javadoc 0m 6s master passed
-0 ⚠️ patch 0m 11s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 47s the patch passed
+1 💚 compile 0m 8s the patch passed
+1 💚 javac 0m 8s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
-1 ❌ whitespace 0m 0s The patch 2 line(s) with tabs.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 6s the patch passed
_ Other Tests _
+1 💚 unit 0m 7s hbase-connectors-assembly in the patch passed.
4m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #41
Optional Tests dupname javac javadoc unit xml compile shellcheck shelldocs
uname Linux 9ec8bbcc752c 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 2bfc5f1
Default Java Oracle Corporation-1.8.0_282-b08
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/whitespace-tabs.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/testReport/
Max. process+thread count 46 (vs. ulimit of 12500)
modules C: hbase-connectors-assembly U: hbase-connectors-assembly
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Connectors-PreCommit/job/PR-41/1/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 2m 50s master passed
+1 💚 compile 0m 9s master passed
+1 💚 javadoc 0m 9s master passed
-0 ⚠️ patch 0m 14s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 15s the patch passed
+1 💚 compile 0m 7s the patch passed
+1 💚 javac 0m 7s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
-1 ❌ whitespace 0m 0s The patch 2 line(s) with tabs.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 6s the patch passed
_ Other Tests _
+1 💚 unit 0m 9s hbase-connectors-assembly in the patch passed.
9m 17s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #41
Optional Tests dupname javac javadoc unit xml compile shellcheck shelldocs
uname Linux da9a557af2a7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / 2bfc5f1
Default Java Oracle Corporation-1.8.0_282-b08
whitespace https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/whitespace-tabs.txt
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-41/1/testReport/
Max. process+thread count 43 (vs. ulimit of 12500)
modules C: hbase-connectors-assembly U: hbase-connectors-assembly
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-41/1/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@taklwu
Copy link
Contributor

taklwu commented Feb 16, 2022

yes I believe the assembly module is the only place we need to have this information.

the stuff that's getting autogenerated right now is the implementation based on the main repo that I mentioned earlier. you can turn it off by removing the plugins that drive the executions aggregate-licenses and concat-NOTICE-files.

sorry if above conversation is a long long time ago, I want to clarify your comment above,

if I read all your conversations correctly, @busbey you're basically saying we don't need this PR because below block of hbase-connectors-assembly has already been autogenerating the right LICENSES and NOTICE when we building the tarball. So can we close this PR and HBASE-22338?

<!-- licensing info from our dependencies -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-remote-resources-plugin</artifactId>
<executions>
<execution>
<id>aggregate-licenses</id>
<goals>
<goal>process</goal>
</goals>
<configuration>
<properties>
<copyright-end-year>${build.year}</copyright-end-year>
<debug-print-included-work-info>${license.debug.print.included}
</debug-print-included-work-info>
<bundled-dependencies>${license.bundles.dependencies}</bundled-dependencies>
<bundled-jquery>${license.bundles.jquery}</bundled-jquery>
<bundled-logo>${license.bundles.logo}</bundled-logo>
<bundled-bootstrap>${license.bundles.bootstrap}</bundled-bootstrap>
</properties>
<resourceBundles>
<resourceBundle>org.apache.hbase:hbase-resource-bundle:${hbase.version}</resourceBundle>
</resourceBundles>
<supplementalModelArtifacts>
<supplementalModelArtifact>org.apache.hbase:hbase-resource-bundle:${hbase.version}
</supplementalModelArtifact>
</supplementalModelArtifacts>
<supplementalModels>
<supplementalModel>supplemental-models.xml</supplementalModel>
</supplementalModels>
</configuration>
</execution>
</executions>
</plugin>

I just open another one that fix the NOTICE.aggregate #93

@taklwu
Copy link
Contributor

taklwu commented Mar 7, 2022

036729d pushed, so closing this PR

@taklwu taklwu closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants