Skip to content

HBASE-22338 LICENSE file only contains Apache 2.0 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taklwu merged 6 commits into from
Mar 7, 2022
Merged

HBASE-22338 LICENSE file only contains Apache 2.0 #93

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d591281
HBASE-22338 LICENSE file only contains Apache 2.0
Feb 16, 2022
c1a2853
remove build.year
Feb 16, 2022
9b447fa
revert version of buildnumber plugin
Feb 17, 2022
95cbf87
copy the LICENSE and NOTICE to tar
Feb 24, 2022
6c4a311
fix ERROR in LICENCE and build number in NOTICE
Mar 1, 2022
3c671b8
add check-aggregate-license
Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hbase-connectors-assembly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,11 @@
<phase>test</phase>
<goals>
<goal>build-classpath</goal>
<goal>copy-dependencies</goal>
</goals>
<configuration>
<outputFile>${project.parent.basedir}/target/cached_classpath.txt</outputFile>
<outputDirectory>${project.build.directory}/dependency</outputDirectory>
</configuration>
</execution>
</executions>
Expand Down
10 changes: 9 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,15 @@
<buildDate>${maven.build.timestamp}</buildDate>
<compileSource>1.8</compileSource>
<java.min.version>${compileSource}</java.min.version>
<!-- override on command line to have generated LICENSE files include
diagnostic info for verifying notice requirements -->
<build.year>2022</build.year>
Copy link
Contributor

@busbey busbey Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we set this already via the buildnumber-maven-plugin. is that not working?

Copy link
Contributor Author

@taklwu taklwu Feb 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during my test, I don't know why it's not working, here is the output https://issues.apache.org/jira/secure/attachment/13040127/NOTICE.aggregate-no-build-year (I did check the hbase code, seems very similar just not working)

Apache HBase Connectors - Assembly
Copyright 2018-${copyright-end-year} The Apache Software Foundation

let me continue to check it.

Copy link
Contributor Author

@taklwu taklwu Feb 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't the reason -.- although I tried to use -Dbuild.year=2022 and it worked.... I will revert the change for this build.year first. let me know if you find any thing. my goal is to have the dependency included in the NOTICE file correctly.

In addition, I'm wondered if we need to add a generated NOTICE for modules of spark e.g. hbase-spark?

Copy link
Contributor Author

@taklwu taklwu Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping ?

Copy link
Contributor

@busbey busbey Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, I'm wondered if we need to add a generated NOTICE for modules of spark e.g. hbase-spark

every artifact we create needs to have a proper LICENSE and NOTICE file. for the most part that should happen automatically for us unless we incorporate third party works in either the source or binary of an artifact.

sorry for the lag, let me look again at what the current artifacts look like with this change in place.

<license.debug.print.included>false</license.debug.print.included>
<license.bundles.dependencies>false</license.bundles.dependencies>
<license.bundles.logo>false</license.bundles.logo>
<license.bundles.bootstrap>false</license.bundles.bootstrap>
<license.bundles.jquery>false</license.bundles.jquery>

<maven.min.version>3.5.0</maven.min.version>
<hbase.version>2.4.9</hbase.version>
<exec.maven.version>1.6.0</exec.maven.version>
Expand Down Expand Up @@ -391,7 +400,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>buildnumber-maven-plugin</artifactId>
<version>1.4</version>
<executions>
<execution>
<phase>validate</phase>
Expand Down