-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Cherry-pick necessary mirror PRs from trunk branch to Branch-3.4 branch #8105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…7 as default (apache#7608) 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24`
* The current version of libxxhash - 0.8.1 isn't available on the msys repo. * This is causing the Hadoop Jenkins CI for Windows to fail while building the docker image for Windows 10. * This PR upgrades libxxhash to 0.8.3 to fix this issue.
apache#7822) * HADOOP-19636. [JDK17] Remove CentOS 7 Support and Clean Up Dockerfile. Co-authored-by: Cheng Pan <[email protected]> Co-authored-by: Istvan Toth <[email protected]> Reviewed-by: Xiaoqiao He <[email protected]> Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Chris Nauroth <[email protected]> Reviewed-by: Cheng Pan <[email protected]> Reviewed-by: Istvan Toth <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Closes apache#7900 Signed-off-by: Shilun Fan <[email protected]> Signed-off-by: Chris Nauroth <[email protected]>
…ckylinux_8 (apache#7917) HADOOP-19661. (Follow-up) Rename Dockerfile_centos_8 to Dockerfile_rockylinux_8. Signed-off-by: Shilun Fan <[email protected]>
…#7898) Contributed by Cheng Pan. * HADOOP-19659. Upgrade Debian 10 to 11 in build env Dockerfile Signed-off-by: Shilun Fan <[email protected]>
…er image (apache#7931) Contributed by Cheng Pan. * HADOOP-19661. (Follow-up) Install missing deps for Rocky Linux 8 docker image Reviewed-by: Shilun Fan <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
… image (apache#7932) Contributed by Cheng Pan. * HADOOP-19659. (Follow-up) Install missing procps for Debian 11 docker image. Signed-off-by: Shilun Fan <[email protected]>
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
@steveloughran Could you please help review this PR? Thank you very much! |
|
there are some unit test failures here which are related to my last change, and that i had missed before merging. This PR fixes those: #8109 |
steveloughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
@steveloughran @ahmarsuhail Thank you very much for helping to review the code. I will directly merge this PR into the branch-3.4 branch. |
|
@steveloughran Apologies, I used the web git merge directly and noticed that the commit history got merged as well. I need to force refresh the branch-3.4 and then push the changes locally. I have submitted a request to temporarily enable force push (https://issues.apache.org/jira/projects/INFRA/issues/INFRA-27460) in order to restore the commit to #8115. |
@ahmarsuhail Thank you for the clarification. I've seen your submission for #8117 and have already given it a +1. |
Description of PR
The purpose of this PR is to maintain consistency in compilation between the
trunkandbranch-3.4. It mainly involves cherry-picking compilation-related PRs from the trunk branch to address theEOL (End of Life)issues ofCentOS 7,CentOS 8, andDebian 10.How was this patch tested?
CI.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?