-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19661. Migrate CentOS 8 to Rocky Linux 8 in build env Dockerfile #7900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Looks like Yetus finds Dockerfile from the trunk branch instead of the PR branch, I'm not very familiar with this part. If the behavior is not easy to change, I'm afraid this PR must be committed first, then we will know what is going to happen. |
@pan3793 Currently, Hadoop's Yetus performs the build twice: first with the trunk code, and then again after applying the patch. At this point, I’m not certain whether what you pointed out is actually an issue. @aajisaka @ayushtkn @GauthamBanasandra Could you please take a look at this issue? Thank you very much! |
|
Would you push the commit to a new branch and then create a test PR based on the branch to check Yetus is working fine? |
|
💔 -1 overall
This message was automatically generated. |
@aajisaka I don't have the permission to commit hadoop repo ... |
|
with the help of @slfan1989, branch
@aajisaka do you have other suggestions? |
@pan3793 Although we can compile locally, there are some issues with Yetus, so I cannot confirm whether this PR will affect other team members' code submissions. I still need @aajisaka @GauthamBanasandra to help verify it. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
I have to rename it back to workaround the @slfan1989 @aajisaka, please take a look, and ping me to revert the renaming change if you think it's ready to go. |
|
@pan3793 LGTM. I don't see any issues. I checked the compilation results and didn't find any problems. |
cnauroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I'll commit this.
This reverts commit b2e0372.
|
💔 -1 overall
This message was automatically generated. |
|
@cnauroth I need to revert the renaming change before committing to trunk ... let me send a follow up to address it |
Closes apache#7900 Signed-off-by: Shilun Fan <[email protected]> Signed-off-by: Chris Nauroth <[email protected]>
…ch (#8105) * HADOOP-19495. Add JDK 24 to Ubuntu 20.04 docker development images. * HADOOP-19540. [JDK17] Add ubuntu:noble as a build platform with JDK-17 as default (#7608) 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24` * HADOOP-19570. Upgrade libxxhash to 0.8.3 in Windows 10 (#7689) * The current version of libxxhash - 0.8.1 isn't available on the msys repo. * This is causing the Hadoop Jenkins CI for Windows to fail while building the docker image for Windows 10. * This PR upgrades libxxhash to 0.8.3 to fix this issue. * HADOOP-19636. [JDK17] Remove CentOS 7 Support and Clean Up Dockerfile. (#7822) * HADOOP-19636. [JDK17] Remove CentOS 7 Support and Clean Up Dockerfile. Co-authored-by: Cheng Pan <[email protected]> Co-authored-by: Istvan Toth <[email protected]> Reviewed-by: Xiaoqiao He <[email protected]> Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Chris Nauroth <[email protected]> Reviewed-by: Cheng Pan <[email protected]> Reviewed-by: Istvan Toth <[email protected]> Signed-off-by: Shilun Fan <[email protected]> * HADOOP-19661. Migrate CentOS 8 to Rocky Linux 8 in build env Dockerfile Closes #7900 Signed-off-by: Shilun Fan <[email protected]> Signed-off-by: Chris Nauroth <[email protected]> * HADOOP-19661. (Follow-up) Rename Dockerfile_centos_8 to Dockerfile_rockylinux_8 (#7917) HADOOP-19661. (Follow-up) Rename Dockerfile_centos_8 to Dockerfile_rockylinux_8. Signed-off-by: Shilun Fan <[email protected]> * HADOOP-19659. Upgrade Debian 10 to 11 in build env Dockerfile (#7898) Contributed by Cheng Pan. * HADOOP-19659. Upgrade Debian 10 to 11 in build env Dockerfile Signed-off-by: Shilun Fan <[email protected]> * HADOOP-19661. (Follow-up) Install missing deps for Rocky Linux 8 docker image (#7931) Contributed by Cheng Pan. * HADOOP-19661. (Follow-up) Install missing deps for Rocky Linux 8 docker image Reviewed-by: Shilun Fan <[email protected]> Signed-off-by: Shilun Fan <[email protected]> * HADOOP-19659. (Follow-up) Install missing procps for Debian 11 docker image (#7932) Contributed by Cheng Pan. * HADOOP-19659. (Follow-up) Install missing procps for Debian 11 docker image. Signed-off-by: Shilun Fan <[email protected]> --------- Signed-off-by: Shilun Fan <[email protected]> Signed-off-by: Chris Nauroth <[email protected]> Co-authored-by: Istvan Toth <[email protected]> Co-authored-by: Vinayakumar B <[email protected]> Co-authored-by: Gautham B A <[email protected]> Co-authored-by: Cheng Pan <[email protected]>
Closes #7900 Signed-off-by: Shilun Fan <[email protected]> Signed-off-by: Chris Nauroth <[email protected]>


Description of PR
Rocky Linux is supposed to be a drop-in replacement for the discontinued CentOS. See more details at https://rockylinux.org/about
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?