YARN-9827.Fix Http Response code in GenericExceptionHandler #4393

hotcodemacha · 2022-05-31T17:29:59Z

Description of PR

Fix Http Response code in GenericExceptionHandler

JIRA: YARN-9827

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

hadoop-yetus · 2022-05-31T19:18:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 59s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 25s		trunk passed
+1 💚	compile	0m 59s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	0m 53s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 49s		trunk passed
+1 💚	mvnsite	0m 57s		trunk passed
+1 💚	javadoc	1m 4s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 53s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 1s		trunk passed
+1 💚	shadedclient	24m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 42s		the patch passed
+1 💚	compile	0m 46s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	0m 46s		the patch passed
+1 💚	compile	0m 41s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 30s		the patch passed
+1 💚	mvnsite	0m 43s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 42s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 50s		the patch passed
+1 💚	shadedclient	23m 49s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	4m 43s		hadoop-yarn-common in the patch passed.
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		107m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4393/1/artifact/out/Dockerfile
GITHUB PR	#4393
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 31650a4161e2 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `8135e79`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4393/1/testReport/
Max. process+thread count	520 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4393/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

aajisaka · 2022-06-06T08:40:05Z

.../hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/GenericExceptionHandler.java

        && e.getCause() instanceof UnmarshalException) {
      s = Response.Status.BAD_REQUEST;
    } else {
      LOG.warn("INTERNAL_SERVER_ERROR", e);


Would you update the log message as well?

Thanks for pointing it out. I have made the changes in next commit.

hadoop-yetus · 2022-06-07T11:38:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	18m 5s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 37s		trunk passed
+1 💚	compile	0m 57s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	0m 53s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 47s		trunk passed
+1 💚	mvnsite	0m 58s		trunk passed
+1 💚	javadoc	1m 4s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 54s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 3s		trunk passed
+1 💚	shadedclient	24m 1s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 42s		the patch passed
+1 💚	compile	0m 47s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	0m 47s		the patch passed
+1 💚	compile	0m 41s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 30s		the patch passed
+1 💚	mvnsite	0m 44s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 42s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 50s		the patch passed
+1 💚	shadedclient	25m 24s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	4m 43s		hadoop-yarn-common in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		126m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4393/2/artifact/out/Dockerfile
GITHUB PR	#4393
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 8300ddfd2699 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c119059`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4393/2/testReport/
Max. process+thread count	620 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4393/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

PrabhuJoseph · 2022-06-20T05:13:35Z

Thanks @ashutoshcipher for the patch and @aajisaka for the review. WIll commit this patch.

) Co-authored-by: Ashutosh Gupta <[email protected]> Reviewed by Akira Ajisaka.

YARN-9827.Fix Http Response code in GenericExceptionHandler

8135e79

aajisaka reviewed Jun 6, 2022

View reviewed changes

Update log message

c119059

hotcodemacha requested a review from aajisaka June 8, 2022 00:02

aajisaka approved these changes Jun 10, 2022

View reviewed changes

PrabhuJoseph merged commit 4f425b6 into apache:trunk Jun 20, 2022

slfan1989 mentioned this pull request Jun 21, 2022

YARN-11169. Support moveApplicationAcrossQueues, getQueueInfo API's for Federation. #4464

Merged

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

YARN-9827.Fix Http Response code in GenericExceptionHandler (apache#4393

56a1db2

) Co-authored-by: Ashutosh Gupta <[email protected]> Reviewed by Akira Ajisaka.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-9827.Fix Http Response code in GenericExceptionHandler #4393

YARN-9827.Fix Http Response code in GenericExceptionHandler #4393

Uh oh!

hotcodemacha commented May 31, 2022

Uh oh!

hadoop-yetus commented May 31, 2022

Uh oh!

aajisaka Jun 6, 2022

Uh oh!

hotcodemacha Jun 7, 2022

Uh oh!

hadoop-yetus commented Jun 7, 2022

Uh oh!

PrabhuJoseph commented Jun 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YARN-9827.Fix Http Response code in GenericExceptionHandler #4393

YARN-9827.Fix Http Response code in GenericExceptionHandler #4393

Uh oh!

Conversation

hotcodemacha commented May 31, 2022

Description of PR

Uh oh!

hadoop-yetus commented May 31, 2022

Uh oh!

aajisaka Jun 6, 2022

Choose a reason for hiding this comment

Uh oh!

hotcodemacha Jun 7, 2022

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jun 7, 2022

Uh oh!

PrabhuJoseph commented Jun 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants