YARN-11169. Support moveApplicationAcrossQueues, getQueueInfo API's for Federation. #4464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2022 20:42
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
The reason why Junit Test failed is because of YARN-9827(pr#4393), a separate PR was submitted to fix YARN-11192(pr#4484). TestRouterWebServicesREST failing after YARN-9827. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Please help me to review the code, Thank you very much! |
goiri
reviewed
Jun 28, 2022
| mockRM.sendAMLaunched(rmApp.getCurrentAppAttempt().getAppAttemptId()); | ||
|
|
||
| MoveApplicationAcrossQueuesRequest acrossQueuesRequest = | ||
| MoveApplicationAcrossQueuesRequest.newInstance(appId,"root.target"); |
Member
There was a problem hiding this comment.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:1142: MoveApplicationAcrossQueuesRequest.newInstance(appId,"root.target");:61: ',' is not followed by whitespace. [WhitespaceAfter]
Contributor
Author
There was a problem hiding this comment.
Thanks for your help reviewing the code, I will fix it.
| Assert.assertNotNull(queueInfo); | ||
| Assert.assertEquals(queueInfo.getQueueName(), "root"); | ||
| Assert.assertEquals(queueInfo.getCapacity(), 4.0, 0); | ||
| Assert.assertEquals(queueInfo.getCurrentCapacity(), 0.0,0); |
Member
There was a problem hiding this comment.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:1168: Assert.assertEquals(queueInfo.getCurrentCapacity(), 0.0,0);:60: ',' is not followed by whitespace. [WhitespaceAfter]
| Assert.assertEquals(queueInfo.getQueueName(), "root"); | ||
| Assert.assertEquals(queueInfo.getCapacity(), 4.0, 0); | ||
| Assert.assertEquals(queueInfo.getCurrentCapacity(), 0.0,0); | ||
| Assert.assertEquals(queueInfo.getChildQueues().size(), 12,0); |
Member
There was a problem hiding this comment.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:1169: Assert.assertEquals(queueInfo.getChildQueues().size(), 12,0);:62: ',' is not followed by whitespace. [WhitespaceAfter]
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Please help me review the code again, thank you very much! |
goiri
approved these changes
Jun 30, 2022
Contributor
Author
|
@goiri Can you help merge this pr to trunk branch? I will follow up with YARN-11160. Thank you very much! |
goiri
approved these changes
Jul 5, 2022
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11169. Support moveApplicationAcrossQueues, getQueueInfo API's for Federation.