Skip to content

YARN-9827.Fix Http Response code in GenericExceptionHandler #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrabhuJoseph merged 2 commits into from
Jun 20, 2022
Merged

YARN-9827.Fix Http Response code in GenericExceptionHandler #4393

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8135e79
YARN-9827.Fix Http Response code in GenericExceptionHandler
May 31, 2022
c119059
Update log message
Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...doop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/GenericExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public Response toResponse(Exception e) {
s = Response.Status.BAD_REQUEST;
} else {
LOG.warn("INTERNAL_SERVER_ERROR", e);
Copy link
Member

@aajisaka aajisaka Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you update the log message as well?

Copy link
Contributor Author

@hotcodemacha hotcodemacha Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. I have made the changes in next commit.

s = Response.Status.INTERNAL_SERVER_ERROR;
s = Response.Status.SERVICE_UNAVAILABLE;
}

// let jaxb handle marshalling data out in the same format requested
Expand Down