HADOOP-18118. Fix KMS Accept Queue Size default value to 500 #3972

GuoPhilipse · 2022-02-09T11:53:05Z

From HADOOP-15638,hadoop.http.socket.backlog.size was set as 500 by default ,we can change code default value to keep consistent.

sync

hadoop-yetus · 2022-02-09T15:30:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	45m 32s		trunk passed
+1 💚	compile	23m 49s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	compile	20m 40s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 4s		trunk passed
+1 💚	mvnsite	1m 47s		trunk passed
+1 💚	javadoc	1m 13s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 37s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 30s		trunk passed
+1 💚	shadedclient	24m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 0s		the patch passed
+1 💚	compile	21m 40s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
-1 ❌	javac	21m 40s	/results-compile-javac-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt	root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 generated 1 new + 1811 unchanged - 0 fixed = 1812 total (was 1811)
+1 💚	compile	19m 38s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌	javac	19m 38s	/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 1 new + 1687 unchanged - 0 fixed = 1688 total (was 1687)
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	1m 7s	/results-checkstyle-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common: The patch generated 1 new + 67 unchanged - 0 fixed = 68 total (was 67)
+1 💚	mvnsite	1m 40s		the patch passed
+1 💚	javadoc	1m 11s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 47s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 38s		the patch passed
+1 💚	shadedclient	22m 24s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 35s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 59s		The patch does not generate ASF License warnings.
		215m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3972/1/artifact/out/Dockerfile
GITHUB PR	#3972
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 2a6a876a7d42 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `53b48b9`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3972/1/testReport/
Max. process+thread count	1296 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3972/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jojochuang

What's the impact of this change?

GuoPhilipse · 2022-02-10T11:21:09Z

hi @jojochuang , no big impact, it is just for keep consistent with the kms-default.xml ,if no value set for the hadoop.http.socket.backlog.size ,500 will also be used. instead of 128 for now.

hadoop-yetus · 2022-02-10T11:22:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 44s		trunk passed
+1 💚	compile	23m 36s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	compile	19m 45s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 9s		trunk passed
+1 💚	mvnsite	1m 41s		trunk passed
+1 💚	javadoc	1m 13s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 45s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 30s		trunk passed
+1 💚	shadedclient	22m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 0s		the patch passed
+1 💚	compile	22m 56s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javac	22m 56s		the patch passed
+1 💚	compile	24m 14s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	24m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 14s	/results-checkstyle-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common: The patch generated 1 new + 67 unchanged - 0 fixed = 68 total (was 67)
+1 💚	mvnsite	1m 54s		the patch passed
+1 💚	javadoc	1m 19s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 57s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 18s		the patch passed
+1 💚	shadedclient	28m 39s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	20m 25s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	0m 58s		The patch does not generate ASF License warnings.
		215m 11s

Reason	Tests
Failed junit tests	hadoop.http.TestHttpServer

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3972/2/artifact/out/Dockerfile
GITHUB PR	#3972
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 38d259d2ba3d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e1aa024`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3972/2/testReport/
Max. process+thread count	3088 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3972/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jojochuang

LGTM

I'm actually surprised the value of the configuration is kept unchanged at 500 in kms-default.xml.

xkrogen · 2022-09-16T17:06:07Z

@GuoPhilipse @jojochuang the test added to TestHttpServer in this patch is failing consistently, and in fact we can see that it failed even in the test run for this PR:

I am going to revert this to unblock other PRs unless I hear back in the next day or so. Thanks.

GuoPhilipse · 2022-09-17T12:02:42Z

@GuoPhilipse @jojochuang the test added to TestHttpServer in this patch is failing consistently, and in fact we can see that it failed even in the test run for this PR:

I am going to revert this to unblock other PRs unless I hear back in the next day or so. Thanks.

thanks @xkrogen for your notice, will take a look soon.

GuoPhilipse · 2022-09-17T13:15:21Z

@xkrogen @jojochuang sorry for the trouble , i refire a pull request to fix the test case failure << #4900 >>,Could you help check that.

…3972)

GuoPhilipse and others added 14 commits November 29, 2020 05:02

Merge pull request #1 from apache/trunk

3c51579

sync

Merge pull request #2 from apache/trunk

a449d04

sync

Merge pull request #3 from apache/trunk

d4f968b

sync

Merge pull request #4 from apache/trunk

d522abf

sync

Merge pull request #5 from apache/trunk

de633b8

sync

Merge pull request #6 from apache/trunk

66ce06b

sync

Merge pull request #7 from apache/trunk

bea061f

sync

Merge pull request #8 from apache/trunk

9375f21

sync

Merge pull request #9 from apache/trunk

56a7aea

sync

Merge pull request #10 from apache/trunk

989f31c

sync

Merge pull request #11 from apache/trunk

60f347a

sync

Merge pull request #12 from apache/trunk

99a3513

sync

fixkmsdefaultvalue

7e9a47c

fixkmsdefaultvalue

53b48b9

fixkmsdefaultvalue

e1aa024

jojochuang reviewed Feb 10, 2022

View reviewed changes

jojochuang approved these changes Feb 23, 2022

View reviewed changes

jojochuang merged commit ce54b7e into apache:trunk Sep 14, 2022

xkrogen mentioned this pull request Sep 16, 2022

HADOOP-18446. [SBN read] Add a re-queue metric to RpcMetrics to quantify the number of re-queued RPCs #4871

Merged

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HADOOP-18118. Fix KMS Accept Queue Size default value to 500 (apache#…

86bc6fe

…3972)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-18118. Fix KMS Accept Queue Size default value to 500 #3972

HADOOP-18118. Fix KMS Accept Queue Size default value to 500 #3972

Uh oh!

GuoPhilipse commented Feb 9, 2022

Uh oh!

hadoop-yetus commented Feb 9, 2022

Uh oh!

jojochuang left a comment

Uh oh!

GuoPhilipse commented Feb 10, 2022

Uh oh!

hadoop-yetus commented Feb 10, 2022

Uh oh!

jojochuang left a comment

Uh oh!

xkrogen commented Sep 16, 2022

Uh oh!

GuoPhilipse commented Sep 17, 2022

Uh oh!

GuoPhilipse commented Sep 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HADOOP-18118. Fix KMS Accept Queue Size default value to 500 #3972

HADOOP-18118. Fix KMS Accept Queue Size default value to 500 #3972

Uh oh!

Conversation

GuoPhilipse commented Feb 9, 2022

Uh oh!

hadoop-yetus commented Feb 9, 2022

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

GuoPhilipse commented Feb 10, 2022

Uh oh!

hadoop-yetus commented Feb 10, 2022

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

xkrogen commented Sep 16, 2022

Uh oh!

GuoPhilipse commented Sep 17, 2022

Uh oh!

GuoPhilipse commented Sep 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants