-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-18446. [SBN read] Add a re-queue metric to RpcMetrics to quantify the number of re-queued RPCs #4871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e number of re-queue RPCs
|
🎊 +1 overall
This message was automatically generated. |
xkrogen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! Small comments on the test impl but generally supportive. I am surprised we didn't add this with the original impl of requeueCall().
...s-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
Outdated
Show resolved
Hide resolved
...ct/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverNode.java
Outdated
Show resolved
Hide resolved
...ct/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverNode.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
xkrogen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments now.
This checkstyle I think we can ignore; all of the metrics in RpcMetrics are set up this way:
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java:132: MutableCounterLong rpcRequeueCalls;:22: Variable 'rpcRequeueCalls' must be private and have accessor methods. [VisibilityModifier]
...ct/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverNode.java
Outdated
Show resolved
Hide resolved
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The failing test in Merging to master, thanks for the contribution @ZanderXu ! |
…ify the number of re-queued RPCs (apache#4871) Signed-off-by: Erik Krogen <xkrogen@apache.org> Co-authored-by: zengqiang.xu <zengqiang.xu@shopee.com>
…ify the number of re-queued RPCs (apache#4871) Signed-off-by: Erik Krogen <xkrogen@apache.org> Co-authored-by: zengqiang.xu <zengqiang.xu@shopee.com>
…ify the number of re-queued RPCs (apache#4871) Signed-off-by: Erik Krogen <xkrogen@apache.org> Co-authored-by: zengqiang.xu <zengqiang.xu@shopee.com>
Description of PR
Add a reQueue metric to RpcMetrics.java to quantify the number of RPCs reQueued. Because Observer NameNode will re-queue the rpc if the call processing should be postponed.
There is no any metric to quantify the number of re-queue RPCs, so I think we should do it.