Change rust.yml to run benchmark #7708
Conversation
|
Now the benchmark actually runs. And build time is significantly shorter (Total duration: 26m 38s). |
.github/workflows/rust.yml
Outdated
| - name: Cache Cargo | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ~/.cargo/bin/ | ||
| ~/.cargo/registry/index/ | ||
| ~/.cargo/registry/cache/ | ||
| ~/.cargo/git/db/ | ||
| ./target/ | ||
| # this key equals the ones on `linux-build-lib` for re-use | ||
| key: cargo-cache-benchmark-${{ hashFiles('datafusion/**/Cargo.toml', 'benchmarks/Cargo.toml') }} |
There was a problem hiding this comment.
Why remove this? Related to the issue?
There was a problem hiding this comment.
Oh, this change is mixed.
There was a problem hiding this comment.
👏
Very nice -- thank you @sarutak
Also, I would like to thank you again for your efforts to make the DataFusion CI work better and more efficiently. It is most appreciated.
I actually spent some more time looking into what plan_q does and it is not at all clear to me it needs to be built in release mode either
It seems like it just verifies the plans (rather than actually running them). I'll see what happens if I change to using debug (rather than release) mode which compiles faster.
* Change rust.yml to run benchmark * Restore unrelated change
Which issue does this PR close?
Closes #7707
Rationale for this change
Run benchmarks as intended.
What changes are included in this PR?
This PR changes
rust.ymlto run benchmark.This PR also changes the cargo command running benchmark to narrow the package to be built, which can reduce the build time.
Are these changes tested?
Done by CI.
Are there any user-facing changes?
No.