Stop using cache for the benchmark job #7706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 1, 2023
There was a problem hiding this comment.
Thank you @sarutak 🙏
This change does indeed make the benchmark verify test take longer (as expected):
I wonder if we are gaining anything from the caching 🤔 When I have played around with caching before, I could never really make a difference
|
Merging to get CI green |
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7705
Rationale for this change
To recover CI.
What changes are included in this PR?
#7678 introduces
actions/cachefor two GA jobs but a cache for the benchmark job seems large, and this can take up the space.So, this PR proposes to stop using the cache for the benchmark job.
Are these changes tested?
Done by GA.
Are there any user-facing changes?
No.