Improve verify benchmark results time (even) more by using debug (rather than release) build
#7709
Labels
enhancement
New feature or request
Comments
|
I see -- the issue appears to be that non release build overflows the stackL
I will add a comment to the file about this rationale |
alamb
added a commit
that referenced
this issue
Oct 1, 2023
…se mode While looking into #7709 I discovered why this test is run in release mode, and I wanted to leave a note for my future self
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this issue
Oct 7, 2023
…se mode (apache#7712) While looking into apache#7709 I discovered why this test is run in release mode, and I wanted to leave a note for my future self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem or challenge?
While reviewing #7708 from @sarutak I spent time looking into what
plan_qdoes and it is not at all clear to me it needs to be built in release mode:https://github.com/apache/arrow-datafusion/blob/46cdb8c2dc495e8063a0adc5c3f9ac82b136e72e/benchmarks/src/tpch/run.rs#L297-L453
Describe the solution you'd like
Since the benchmark verifies the plans (rather than actually running them). I think it is ok to use debug mode (rather than release) mode which compiles faster and will have more reuse with the subsequent call to
cargo test --test sqllogictestsDescribe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: