Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugins] Drop Node 4 support #72

Closed
7 of 16 tasks
timbru31 opened this issue Jan 30, 2019 · 8 comments
Closed
7 of 16 tasks

[Plugins] Drop Node 4 support #72

timbru31 opened this issue Jan 30, 2019 · 8 comments
Assignees
@timbru31
Labels
enhancement New feature or request plugins

Comments

@timbru31
Copy link
Member

timbru31 commented Jan 30, 2019 •
edited
Loading

As per #5, but this time for plugins:

Goal

  • Drop Node 4 Support

List of active core plugins
@timbru31 timbru31 changed the title Drop Node 4 Support Drop Node 4 support for plugins Jan 30, 2019
This was referenced Jan 30, 2019
Merged
Merged
Closed
@janpio janpio changed the title Drop Node 4 support for plugins [Pugins] Drop Node 4 support Jan 30, 2019
timbru31 added a commit to timbru31/cordova-plugin-battery-status that referenced this issue Mar 2, 2019
@timbru31
chore: drop Node.js v4 support
176bfd7 
Part of apache/cordova#72
@timbru31 timbru31 mentioned this issue Mar 2, 2019
Merged
5 tasks
timbru31 added a commit to timbru31/cordova-plugin-battery-status that referenced this issue Mar 2, 2019
@timbru31
chore: drop Node.js v4 support
7fa1f3e 
Part of apache/cordova#72
timbru31 added a commit to timbru31/cordova-plugin-network-information that referenced this issue Mar 2, 2019
@timbru31
chore: drop Node.js v4 support
a0f43d9 
Part of apache/cordova#72
@timbru31 timbru31 mentioned this issue Mar 2, 2019
Merged
5 tasks
timbru31 added a commit to timbru31/cordova-plugin-battery-status that referenced this issue Mar 2, 2019
@timbru31
chore: drop Node.js v4 support
666bbb2 
Part of apache/cordova#72
janpio pushed a commit to apache/cordova-plugin-battery-status that referenced this issue Mar 4, 2019
@timbru31 @janpio
chore: drop Node.js v4 support (#73)
83c6e44 
Part of apache/cordova#72

<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:

http://cordova.apache.org/contribute/contribute_guidelines.html

Thanks!
-->

### Platforms affected

n/a - development

### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->

Drops EOL Node.js 4 from CI config. BREAKING CHANGE! :)

### Description
<!-- Describe your changes in detail -->

see above.

### Testing
<!-- Please describe in detail how you tested your changes. -->

TravisCI and Appveyor test results.

### Checklist

- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
@janpio janpio added the enhancement New feature or request label Apr 10, 2019
This was referenced Apr 10, 2019
Merged
Merged
@janpio janpio added the plugins label Apr 16, 2019
janpio pushed a commit to apache/cordova-plugin-wkwebview-engine that referenced this issue Apr 18, 2019
@timbru31 @janpio
chore: drop Node.js v4 support (#91)
1f1a888 
Part of apache/cordova#72

<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:

http://cordova.apache.org/contribute/contribute_guidelines.html

Thanks!
-->

### Platforms affected

n/a - development

### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->

Drops EOL Node.js 4 from CI config. BREAKING CHANGE! :)

### Description
<!-- Describe your changes in detail -->

see above.

### Testing
<!-- Please describe in detail how you tested your changes. -->

TravisCI and Appveyor test results.

### Checklist

- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
@timbru31 timbru31 self-assigned this Apr 23, 2019
@timbru31
Copy link
Member Author

timbru31 commented Apr 23, 2019 •
edited
Loading

Due to major releases (Cordova CLI v9, cordova-android v8, cordova-ios v5) I've unchecked all plugins since the CI won't work currently with those outdated Xcode images nor the unchecked licenses for Android SDKs. First candidate to cleanup this, too, is: apache/cordova-plugin-vibration#76

For reference, broken TravisCI builds: https://travis-ci.org/apache/cordova-plugin-vibration/jobs/523723056#L2302 & https://travis-ci.org/apache/cordova-plugin-vibration/jobs/523723055#L2209

@brodycj
Copy link

brodycj commented Apr 24, 2019

I would not favor supporting Node.js version 6 for much longer, considering that its scheduled EOL is just a few days away.

@timbru31
Copy link
Member Author

+1 that’s what I’ve though of, too :)

@erisu erisu mentioned this issue Apr 24, 2019
Closed
5 tasks
@janpio
Copy link
Member

janpio commented Apr 24, 2019

I'll copy over what I wrote at apache/cordova-plugin-vibration#76 (comment):

We have a passing state at paramedic, so now we'll see what happens with the first plugins. apache/cordova-plugin-inappbrowser#465 is the other first try to adapt the configuration from there.

When we have that (currently tests are failing on iOS 12.2 - not sure if this is a problem with the plugin or with the test setup yet) and vibration in a good state, we can start rolling that out to more plugins and see what happens.

@janpio
Copy link
Member

janpio commented May 10, 2019

travis.yml changes have been created as PRs for all plugins. This included going to node 6 for all of these configurations. I wrote a dev mailing list message which gives an overview: https://lists.apache.org/thread.html/959ebe1683ac8ac10013d70a514bdf213ac6935ffd28fd045b269ab6@%3Cdev.cordova.apache.org%3E

Now we probably only need PRs for appveyor.yml and possibly updated to package.json.

@janpio janpio changed the title [Pugins] Drop Node 4 support [Plugins] Drop Node 4 support Jul 11, 2019
@janpio
Copy link
Member

janpio commented Jul 11, 2019 •
edited
Loading

Plugins were released with green CI, so this should already be taken care of for all plugins - correct? If not, now would be a good time to create the PRs.

@erisu
Copy link
Member

erisu commented Jul 17, 2019

@janpio I did a quick review though those remaining plugin's master branch and this is the results:

Completed and can be updated in ticket desc.

  • cordova-plugin-camera (travis: 8 appveyor: 6)

Unfinished and need PRs

  • cordova-plugin-device (travis: 8 appveyor: 4)
  • cordova-plugin-dialogs (travis: 8 appveyor: 4)
  • cordova-plugin-file (travis: 8 appveyor: 4)
  • cordova-plugin-geolocation (travis: 8 appveyor: 4)
  • cordova-plugin-inappbrowser (travis: 8 appveyor: 4)
  • cordova-plugin-media (travis: 8 appveyor: 4)
  • cordova-plugin-media-capture (travis: 8 appveyor: 4)
  • cordova-plugin-splashscreen (travis: 8 appveyor: 4)

AppVeyor could actually be bumped to node 8 to match with Travis CI configs. If that is preferred, then camera and maybe the already completed items would need revisits.

@timbru31
Copy link
Member Author

Closing in favor of #79

craigmcnamara pushed a commit to mes-amis/cordova-plugin-wkwebview-engine that referenced this issue Aug 5, 2020
@timbru31 @craigmcnamara
chore: drop Node.js v4 support (apache#91)
459b0a2 
Part of apache/cordova#72

<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:

http://cordova.apache.org/contribute/contribute_guidelines.html

Thanks!
-->

### Platforms affected

n/a - development

### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->

Drops EOL Node.js 4 from CI config. BREAKING CHANGE! :)

### Description
<!-- Describe your changes in detail -->

see above.

### Testing
<!-- Please describe in detail how you tested your changes. -->

TravisCI and Appveyor test results.

### Checklist

- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timbru31 timbru31

Labels
enhancement New feature or request plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janpio @timbru31 @erisu @brodycj