ci(travis): Update Travis CI configuration for new paramedic #465

erisu · 2019-04-24T04:44:28Z

Platforms affected

none

Motivation and Context

Match Paramedic Test
Update Package.json

Description

Updated Travis CI to test local and same set of platforms that paramedic tests.
Updated package.json

Testing

Checklist

I've run the tests to see all new and existing tests pass
I added automated test coverage as appropriate for this change
Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
I've updated the documentation if necessary

erisu · 2019-04-24T06:34:17Z

Tagging: apache/cordova#72

timbru31 · 2019-04-24T09:10:05Z

package.json

@@ -15,10 +15,11 @@
  },
  "repository": {
    "type": "git",
-    "url": "https://github.com/apache/cordova-plugin-inappbrowser"
+    "url": "github:apache/cordova-plugin-inappbrowser"


Shouldn't this be the complete shorthand syntax?
"repository": "github:apache/cordova-plugin-inappbrowser" - personally I'd drop the github: part, too. Recent npm versions should be intelligent enough to resolve this to GitHub

I just wrote a script that updated the existing URL. I didn't think of shortening the entire field to a string.

Yeah we can shorten it more.

https://docs.npmjs.com/files/package.json#repository

I wonder what is the order of priority if you dropped GitHub from the string.

"repository": "npm/npm" "repository": "github:user/repo" "repository": "gist:11081aaa281" "repository": "bitbucket:user/repo" "repository": "gitlab:user/repo"

Might be bad if someone else took our exist same username and repo name for in another git service and NPM decided to use the wrong one.. Or one day they screw up the order of priority.

That could happen, but I don't believe it's that probable ;)
Having github: doesn't hurt though.

janpio · 2019-04-24T09:48:12Z

.travis.yml

- node /tmp/paramedic/main.js --config pr/$PLATFORM --plugin $(pwd) --shouldUseSauce
-  --buildName travis-plugin-inappbrowser-$TRAVIS_JOB_NUMBER
+- if [[ "$PLATFORM" != local ]]; then cordova-paramedic --config pr/$PLATFORM --plugin $(pwd) --buildName $PARAMEDIC_BUILDNAME --shouldUseSauce; fi
+- if [[ "$PLATFORM" =~ local ]]; then cordova-paramedic --config pr/local/ios-10.0 --plugin $(pwd) --buildName $PARAMEDIC_BUILDNAME; fi


That's interesting. I dislike the hardcoding of ios-10.0 down here, but like that it doesn't reroute through package.json/npm script.

Since the --config value is append at paramedic's conf directory path, I was thinking what if PLATFORM was changed to local/ios-10 instead.

Then the line will remain as

- if [[ "$PLATFORM" =~ local ]]; then cordova-paramedic --config pr/$PLATFORM --plugin $(pwd) --buildName $PARAMEDIC_BUILDNAME; fi

Though PLATFORM=local/ios-10, "$PLATFORM" =~ local will still match.

Only thing is I have not looked into is if this environment variable is used within paramedic code... if not and only within this yaml file, I think it will be OK to change as well.

Sounds good!

janpio · 2019-04-24T09:49:31Z

Interesting test failure on Xcode 10.2, iOS 12.2:

https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/523799304

cordova-paramedic: connecting webdriver
....................................................................
No webview context. Retries remaining: 2
cordova-paramedic: Tests failed to complete; ending appium session. The error is:
Error: [context("WEBVIEW_5250.2")] Error response status: 13, UnknownError - An unknown server-side error occurred while processing the command. Selenium error: An unknown server-side error occurred while processing the command. Original error: Remote debugger error with code '-32601': 'Page' domain was not found
    at exports.newError (/Users/travis/.nvm/versions/node/v6.17.1/lib/node_modules/cordova-paramedic/node_modules/wd/lib/utils.js:152:13)
    at /Users/travis/.nvm/versions/node/v6.17.1/lib/node_modules/cordova-paramedic/node_modules/wd/lib/callbacks.js:36:19
    at /Users/travis/.nvm/versions/node/v6.17.1/lib/node_modules/cordova-paramedic/node_modules/wd/lib/webdriver.js:194:5
    at Request._callback (/Users/travis/.nvm/versions/node/v6.17.1/lib/node_modules/cordova-paramedic/node_modules/wd/lib/http-utils.js:89:7)
    at Request.self.callback (/Users/travis/.nvm/versions/node/v6.17.1/lib/node_modules/cordova-paramedic/node_modules/request/request.js:185:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)
    at Request.<anonymous> (/Users/travis/.nvm/versions/node/v6.17.1/lib/node_modules/cordova-paramedic/node_modules/request/request.js:1161:10)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
From previous event:
    at ParamedicSauceLabs.runSauceTests (/Users/travis/.nvm/versions/node/v6.17.1/lib/node_modules/cordova-paramedic/lib/ParamedicSauceLabs.js:459:14)
    at ParamedicRunner.runTests (/Users/travis/.nvm/versions/node/v6.17.1/lib/node_modules/cordova-paramedic/lib/paramedic.js:328:58)
    at Q.then.then.then (/Users/travis/.nvm/versions/node/v6.17.1/lib/node_modules/cordova-paramedic/lib/paramedic.js:89:29)

https://app.saucelabs.com/tests/2c2ca315b8af49bd8a8e5b34409032a8

janpio · 2019-04-24T10:00:36Z

appium/appium#12510 and appium/appium#12518 sound related - second one has a possible workaround/solution to look into.

erisu · 2019-04-24T10:06:40Z

@janpio thanks for the two appium tickets as references, I will look into them.

purplecabbage

We shouldn’t be sending people to [email protected] just discuss in the issue thread. I have to approve people to send mail there ...
The rest looks great.

erisu · 2019-04-25T01:55:24Z

@purplecabbage I can drop the email. I only added it to be consistent with other repos that already had it. I will make sure to remove it from the other repos as well when I come across them.

purplecabbage · 2019-04-25T03:30:14Z

I guess if it’s in all the others then it’s fine. I’m not trying to make more work for any of us. I just thought it was a new thing ..

janpio · 2019-05-10T22:00:31Z

Newer version of the travis.yml is no suggested for merge in #478 (but is failing for the same reasons)

timbru31 reviewed Apr 24, 2019

View reviewed changes

janpio reviewed Apr 24, 2019

View reviewed changes

This was referenced Apr 24, 2019

chore: drop Node.js v4 support from AppVeyor apache/cordova-plugin-vibration#76

Merged

[Plugins] Drop Node 4 support apache/cordova#72

Closed

purplecabbage reviewed Apr 24, 2019

View reviewed changes

erisu added 2 commits April 25, 2019 11:06

Update Travis CI Config

a6beead

Update NPM Package Node Requirement and Others

bbd04bf

erisu force-pushed the test-updates branch from 7964a00 to bbd04bf Compare April 25, 2019 02:06

TMP: Use Updated Config Branch

f2ad1a7

erisu force-pushed the test-updates branch from 400070a to f2ad1a7 Compare April 26, 2019 05:35

janpio mentioned this pull request May 10, 2019

InAppBrowser plugin has problems running tests on SauceLabs on iOS 12.2 apache/cordova-paramedic#149

Open

janpio changed the title ~~Updated Travis CI Settings and Package.json~~ ci(travis): Update Travis CI configuration for new paramedic Jun 18, 2019

janpio closed this Jun 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(travis): Update Travis CI configuration for new paramedic #465

ci(travis): Update Travis CI configuration for new paramedic #465

erisu commented Apr 24, 2019

erisu commented Apr 24, 2019

timbru31 Apr 24, 2019

erisu Apr 24, 2019 •

edited

Loading

timbru31 Apr 24, 2019

janpio Apr 24, 2019

erisu Apr 24, 2019 •

edited

Loading

janpio Apr 24, 2019

janpio commented Apr 24, 2019

janpio commented Apr 24, 2019

erisu commented Apr 24, 2019

purplecabbage left a comment

erisu commented Apr 25, 2019

purplecabbage commented Apr 25, 2019 via email •

edited

Loading

janpio commented May 10, 2019

ci(travis): Update Travis CI configuration for new paramedic #465

ci(travis): Update Travis CI configuration for new paramedic #465

Conversation

erisu commented Apr 24, 2019

Platforms affected

Motivation and Context

Description

Testing

Checklist

erisu commented Apr 24, 2019

timbru31 Apr 24, 2019

Choose a reason for hiding this comment

erisu Apr 24, 2019 • edited Loading

Choose a reason for hiding this comment

timbru31 Apr 24, 2019

Choose a reason for hiding this comment

janpio Apr 24, 2019

Choose a reason for hiding this comment

erisu Apr 24, 2019 • edited Loading

Choose a reason for hiding this comment

janpio Apr 24, 2019

Choose a reason for hiding this comment

janpio commented Apr 24, 2019

janpio commented Apr 24, 2019

erisu commented Apr 24, 2019

purplecabbage left a comment

Choose a reason for hiding this comment

erisu commented Apr 25, 2019

purplecabbage commented Apr 25, 2019 via email • edited Loading

janpio commented May 10, 2019

erisu Apr 24, 2019 •

edited

Loading

erisu Apr 24, 2019 •

edited

Loading

purplecabbage commented Apr 25, 2019 via email •

edited

Loading