Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop Node.js v4 support from AppVeyor #76

Merged
merged 4 commits into from
May 16, 2019

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Jan 30, 2019

Part of apache/cordova#72

Platforms affected

n/a - development

Motivation and Context

Drops EOL Node.js 4 from CI config. BREAKING CHANGE! :)

Description

see above.

Testing

TravisCI and Appveyor test results.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@janpio
Copy link
Member

janpio commented Jan 30, 2019

Uh, this should get an issue in https://github.com/apache/cordova as a collection for all plugins. Then all the PRs can link to that issue, we can make sure all plugins were taken care of etc.

Is this already based on something we did for another Cordova repo? (these CI configs should be pretty much copy/paste to all similar repos in the best case)

@timbru31
Copy link
Member Author

We had apache/cordova#5, but just for tooling and platforms

@janpio
Copy link
Member

janpio commented Jan 30, 2019

Yeah, go ahead and create a new one. It's worth to centralize these things, otherwise someone will have to go through all repos in the future and make sure the all use the same config.

@timbru31
Copy link
Member Author

There we go: apache/cordova#72

@janpio
Copy link
Member

janpio commented Jan 30, 2019

Great. See my PR comments on https://github.com/apache/cordova-plugin-statusbar/pull/124/files before you continue please.

@timbru31 timbru31 changed the title chore: drop Node.js v4 support WIP: chore: drop Node.js v4 support Feb 19, 2019
this is a BREAKING CHANGE
@timbru31 timbru31 changed the title WIP: chore: drop Node.js v4 support chore: drop Node.js v4 support Apr 10, 2019
@timbru31
Copy link
Member Author

@janpio - ready for review now

@timbru31 timbru31 requested a review from janpio April 23, 2019 22:41
@timbru31
Copy link
Member Author

timbru31 commented Apr 23, 2019

CI passes again, see apache/cordova#72 (comment) - I've used the same matrix as in https://github.com/apache/cordova-paramedic.
If paramedic is finished I can continue to update the other plugins. /cc @erisu

@janpio
Copy link
Member

janpio commented Apr 24, 2019

We have a passing state at paramedic, so now we'll see what happens with the first plugins. apache/cordova-plugin-inappbrowser#465 is the other first try to adapt the configuration from there.

I think you missed the local test for your adaptation here.
But all the tests passing is nice.

@timbru31
Copy link
Member Author

timbru31 commented Apr 24, 2019

I think you missed the local test for your adaptation here.

Indeed

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes on travis.yml were replaced by #80 - please remove those from this PR so it can be merged. thanks.

@timbru31
Copy link
Member Author

timbru31 commented May 16, 2019

Obsolete with #80 - whoops, AppVeyor is still relevant.

@timbru31 timbru31 closed this May 16, 2019
@timbru31 timbru31 deleted the feat/drop-node-v4 branch May 16, 2019 14:16
@timbru31 timbru31 restored the feat/drop-node-v4 branch May 16, 2019 14:16
@timbru31 timbru31 reopened this May 16, 2019
@timbru31 timbru31 changed the title chore: drop Node.js v4 support chore: drop Node.js v4 support from AppVeyor May 16, 2019
@timbru31 timbru31 requested a review from janpio May 16, 2019 14:18
@timbru31 timbru31 merged commit 2438539 into apache:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants