-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AVRO-3446: Add avrogen unit tests #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3446: Add avrogen unit tests #1595
Conversation
|
@martin-g @RyanSkraba We have some work in progress and PR done for avrogen. This PR makes very minimal (non-functional) changes to avrogen, however it adds a good amount of testing for the code generation. IMO this could be a very solid base line testing before we make any changes to avrogen. This changes should mofify or add new unit tests. This way we have more confidence in the changes. I had a pending PR #1574 which had these unit tests, however I think it is a better sequencing if we add the baseline testing first to reflect and test the current avrogen status. The tests include the following:
If you agree we can prioritize this PR so, e.g. #1578 can add unit tests to validate the new skipped directory structure |
|
The Travis CI support is very slooow. Is there anything that travis.yml covers, which is not covered by the git flow actions? Can it be retired? Many times Travis takes hours to be finished. |
|
I'm good with the intention of this, but I do want to break the functionality of the AvroGen class into a separate class. Keep the "program" entry point to just deal with parsing the input. The other option is taking advantage of the strong naming to sign the assembly. |
|
Note that there is an AvroGenTests, for that reason. Most functionality will be moved to the libraryaa you said. And AvroGenToolTests will be the tool specific tests. This will be done in steps to make sure that current functionality is not altered by the actual rework. |
Co-authored-by: Martin Grigorov <[email protected]>
Co-authored-by: Martin Grigorov <[email protected]>
|
Should this be cherry-picked to 1.11.1 ? It seems like a good candidate! |
* Add avrogen unit tests * Hide dynamic compiler errors * Add asserts * Bump MSBUild package versions * Tweak dotnet 6.0 install * Add comments * Use 6.0.2xx channel * Revert dotnet-install change * Add codegen tests * Add test for contextual keyword in namespace * Add AvroGenHelper * Update lang/csharp/src/apache/main/CodeGen/CodeGenUtil.cs Co-authored-by: Martin Grigorov <[email protected]> * Update lang/csharp/src/apache/test/AvroGen/AvroGenHelper.cs Co-authored-by: Martin Grigorov <[email protected]> Co-authored-by: Zoltan Csizmadia <[email protected]> Co-authored-by: Martin Grigorov <[email protected]>
|
@RyanSkraba adding it to 1.11.1 makes sense. These unit tests IMO are a must have to provide a base line test coverage to the code generation and avrogen, which was not covered before. |
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation