-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AVRO-3425: Extend C# avrogen namespace mapping to models and members as well #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3425: Extend C# avrogen namespace mapping to models and members as well #1574
Conversation
|
This rework changes how the namespace mapping is done. In this approach all the "namespace" definitions in the original schema definition text are replaced by the new mapped namespace name, before the schema is even parsed. |
|
@RyanSkraba @martin-g Added soem IMO cool integration tests for
It does these without namespace mapping, with simple namespace mapping and with namespace mapping where the mapped namespace has reserved words in it. |
|
@martin-g I think it is ready for review: Added several avrogen related tests:
|
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation
Potentially fixes:
https://issues.apache.org/jira/browse/AVRO-2883
https://issues.apache.org/jira/browse/AVRO-3046