-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AVRO-3435: Add --version to avrogen tool #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3435: Add --version to avrogen tool #1583
Conversation
|
Unit tests should be added after #1595 is merged |
| return 0; | ||
| } | ||
|
|
||
| if (args.Contains("--version")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the expectation to also support -V? args.Any(a => a is "--version" or "-V") <-- Apparently this is only C# 8
if (args.Contains("--version") || args.Contains("-V") )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I added -V to the cpp avrogen and I intended to add for C# as well.
|
@martin-g I added some addition unit tests to make sure that the version returned by avrogen and the version for the main library match and both are SemVer2.0 compliant. Additionally added some tests to make sure that some mandatory attrributes are always defined (e.g. Company, Description ...) |
* Add version to avrogen * Use DefaultExeTargetFrameworks from common.props * Add version to avrogencpp * Remove file version check Co-authored-by: Zoltan Csizmadia <[email protected]> (cherry picked from commit 4fc9e23)
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation