Skip to content

Conversation

@zcsizmadia
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the C# label Mar 7, 2022
@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Mar 7, 2022
@zcsizmadia
Copy link
Contributor Author

Unit tests should be added after #1595 is merged

return 0;
}

if (args.Contains("--version"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the expectation to also support -V? args.Any(a => a is "--version" or "-V") <-- Apparently this is only C# 8
if (args.Contains("--version") || args.Contains("-V") )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I added -V to the cpp avrogen and I intended to add for C# as well.

@zcsizmadia
Copy link
Contributor Author

@martin-g I added some addition unit tests to make sure that the version returned by avrogen and the version for the main library match and both are SemVer2.0 compliant. Additionally added some tests to make sure that some mandatory attrributes are always defined (e.g. Company, Description ...)

@martin-g martin-g merged commit 4fc9e23 into apache:master Mar 30, 2022
martin-g pushed a commit that referenced this pull request Mar 30, 2022
* Add version to avrogen

* Use DefaultExeTargetFrameworks from common.props

* Add version to avrogencpp

* Remove file version check

Co-authored-by: Zoltan Csizmadia <[email protected]>
(cherry picked from commit 4fc9e23)
@zcsizmadia zcsizmadia deleted the avro-3435-add-version-to-avrogen branch March 30, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ Pull Requests for C++ binding C#

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants