Skip to content

ARROW-16201: [R] SafeCallIntoR on 3.4 #12887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonkeane wants to merge 5 commits into from
Closed

ARROW-16201: [R] SafeCallIntoR on 3.4 #12887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13d8c59
skip safecallintor on 3.4
jonkeane Apr 14, 2022
e20d179
actualy save the file first
jonkeane Apr 14, 2022
41caced
slightly different skip location
jonkeane Apr 14, 2022
975bdd5
oops, needs to be 3.4.4
jonkeane Apr 14, 2022
0d5057f
also skip some datetime + tzone tests on 3.4
jonkeane Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions r/tests/testthat/test-dplyr-funcs-datetime.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
# under the License.

skip_if(on_old_windows())
# In 3.4 the lack of tzone attribute causes spurious failures
skip_if_r_version("3.4.4")

library(lubridate, warn.conflicts = FALSE)
library(dplyr, warn.conflicts = FALSE)
Expand Down
2 changes: 2 additions & 0 deletions r/tests/testthat/test-dplyr-funcs-type.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,6 +877,8 @@ test_that("as.Date() converts successfully from date, timestamp, integer, char a

test_that("format date/time", {
skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
# In 3.4 the lack of tzone attribute causes spurious failures
skip_if_r_version("3.4.4")

times <- tibble(
datetime = c(lubridate::ymd_hms("2018-10-07 19:04:05", tz = "Pacific/Marquesas"), NA),
Expand Down
1 change: 1 addition & 0 deletions r/tests/testthat/test-safe-call-into-r.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ test_that("SafeCallIntoR works within RunWithCapturedR", {
})

test_that("SafeCallIntoR errors from the non-R thread", {
skip_if_r_version("3.4.4")
Copy link
Member

@paleolimbot paleolimbot Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still get skipped, but I can also make sure that we error instead of crash #if !defined(HAS_UNWIND_PROTECT) (probably more important for #12323 since we'll be actually using it there). Actually, that PR is probably a better place to fix it (I'll make sure to rebase and run the test-r-versions on that PR on Monday).

skip_on_cran()

expect_error(
Expand Down