ARROW-16201: [R] SafeCallIntoR on 3.4 #12887
Conversation
|
@github-actions crossbow submit -g test-r-versions |
|
|
@github-actions crossbow submit test-r-versions |
|
Revision: e20d179 Submitted crossbow builds: ursacomputing/crossbow @ actions-1857
|
|
@github-actions crossbow submit test-r-versions |
|
Revision: 975bdd5 Submitted crossbow builds: ursacomputing/crossbow @ actions-1860
|
|
@github-actions crossbow submit test-r-versions |
|
Revision: 0d5057f Submitted crossbow builds: ursacomputing/crossbow @ actions-1861
|
| }) | ||
|
|
||
| test_that("SafeCallIntoR errors from the non-R thread", { | ||
| skip_if_r_version("3.4.4") |
There was a problem hiding this comment.
This should still get skipped, but I can also make sure that we error instead of crash #if !defined(HAS_UNWIND_PROTECT) (probably more important for #12323 since we'll be actually using it there). Actually, that PR is probably a better place to fix it (I'll make sure to rebase and run the test-r-versions on that PR on Monday).
|
Benchmark runs are scheduled for baseline = 76e4f53 and contender = 63d2a9c. 63d2a9c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
Disabling the tests for now, 3.4 will no longer be in our support window shortly with the release of 4.2 also skip a number of tests that failed because of
tzonebeing non-present on 3.4.