Add reactiveStore to PendingRpcRequest#1555
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f48797d The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 22, 2026
BundleMonFiles updated (4)
Unchanged files (143)
Total files change +522B +0.1% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-1hqmgirgi-anza-tech.vercel.app |
mcintyre94
force-pushed
the
rpc-reactive
branch
from
06c7974 to
eb8b21a
Compare
Member
Author
trevor-cortex
left a comment
trevor-cortex
left a comment
There was a problem hiding this comment.
Nice, clean addition. The reactiveStore() method mirrors the existing PendingRpcSubscriptionRequest.reactiveStore() pattern, and the implementation is a tiny, easy-to-reason-about wrapper: createReactiveActionStore + immediate auto-dispatch. Docblock + README + changeset + tests are all in place. LGTM modulo the comments below.
Summary
- New
reactiveStore(): ReactiveActionStore<[], TResponse>method onPendingRpcRequest, auto-fires on construction and returns a store with the standard{ subscribe, getState, dispatch, dispatchAsync, reset }contract. @solana/subscribableadded as a runtime dep of@solana/rpc-spec.ES2024.Promiseadded to therpc-spectsconfiglib(needed forPromise.withResolvers()in the new tests).- Mock
PendingRpcRequestshapes updated across several packages (accounts,kit,rpc-graphql,transaction-confirmation) to satisfy the expanded type. - New CLAUDE.md guidance about preferring
jest.useFakeTimers()+runAllTimersAsync()over hand-rolled microtask flushers, which the new tests themselves follow.
Things to watch / notes for subsequent reviewers
- No external
abortSignaloption onreactiveStore()— unlikesend({ abortSignal }). Consumers tie cancellation tostore.reset()or letdispatch()supersede in-flight calls. The PR description mentions the escape hatch (createActionStore((signal) => rpc.getAccountInfo(address).send({ abortSignal: signal }))), which is fine, but worth confirming this is the intended ergonomic — a follow-up that accepts an external signal wouldn't be a breaking change, so deferring is reasonable. - Auto-dispatch semantics: the
ReactiveActionStorereturned here can re-enteridleviareset()but not re-enterrunningwithout an explicitdispatch(). Documented in the changeset/README; flagging because it's the main behavioural subtlety. @solana/subscribablein@solana/rpc-spec's runtime deps pulls theevent-target-impl/promiseschain into the spec package. Consistent with the subscription-side precedent, but it does slightly expand the spec package's surface — worth a sanity-check.- Test hygiene: the new
describeinstalls fake timers inbeforeEachwith no matchingafterEachto restore real timers — see inline comment. - Bundle-size impact on
@solana/kitvia the new transitive dep — BundleMon will tell us, but worth eyeballing.
Comment on lines
118
to
+122
| plan: RpcPlan<TResponse>, | ||
| ): PendingRpcRequest<TResponse> { | ||
| return { | ||
| reactiveStore(): ReactiveActionStore<[], TResponse> { | ||
| const store = createReactiveActionStore<[], TResponse>(signal => plan.execute({ signal, transport })); |
There was a problem hiding this comment.
Question (non-blocking): would it be worth accepting an optional { abortSignal } here, mirroring send(options)? Use cases: binding the store's lifetime to a parent controller (e.g. Svelte onDestroy, Vue onScopeDispose, or a composed cancellation tree) without having to manually wire reset(). The escape-hatch pattern in the PR description (createActionStore(signal => ...send({ abortSignal: signal }))) works but loses the one-liner ergonomics. Happy to defer — this is purely additive and can be layered on later.
Member
Author
There was a problem hiding this comment.
Considered this but I don't think it's needed. There's nothing that can leak here - the http request is abortable and doesn't leave anything behind. In contrast to subscriptions where we have a subscription to clean up.
Having both signals requires fiddly wiring in subscriptions, which is worth it there but would just be complexity for no value here IMO.
mcintyre94
force-pushed
the
rpc-reactive
branch
from
eb8b21a to
d404b62
Compare
mcintyre94
force-pushed
the
action-store
branch
from
0e977ea to
1a53c39
Compare
mcintyre94
force-pushed
the
rpc-reactive
branch
from
d404b62 to
0c6eab5
Compare
lorisleiva
approved these changes
May 5, 2026
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Sorry for the late review, looks good to me! 👌
Member
Author
Merge activity
|
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds
.reactiveStore()toPendingRpcRequest, similar to how we use it forPendingRpcSubscriptionRequest. This sends the request and synchronously returns aReactiveActionStore.As with our other reactive store features, this is intended to provide a better API for reactive consumers:
Note that this has auto-dispatch semantics, meaning calling it has the same sort of behaviour as calling
send()or the similarreactiveStore()on subscriptions.Consumers that want to control sending precisely can use
createActionStore((signal) => rpc.getAccountInfo(address).send({abortSignal: signal})- this is just a thin wrapper that adds auto-dispatch and therefore skips theidlestate.