Rename ReactiveStore to ReactiveStreamStore#1554
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 248de10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
BundleMonUnchanged files (147)
Total files change +36B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
trevor-cortex
left a comment
trevor-cortex
left a comment
There was a problem hiding this comment.
Pure rename of ReactiveStore<T> → ReactiveStreamStore<T> to make room for the orthogonal ReactiveActionStore planned in #1550. No behavioural changes.
What the PR does:
- Renames the source file
reactive-store.ts→reactive-stream-store.ts(and its test counterpart) and updates thesubscribablepackage barrel. - Renames the exported type and re-exports
ReactiveStore<T>as a@deprecatedalias ofReactiveStreamStore<T>so existing consumers don't break. - Updates all
{@link}references (in thesubscribable,kit, andrpc-subscriptions-specpackages) and the matching prose in both READMEs and theSOLANA_ERROR__SUBSCRIBABLE__RETRY_NOT_SUPPORTEDmessage. - Updates the consumer-facing return types of
PendingRpcSubscriptionsRequest.reactive()/reactiveStore()and ofcreateReactiveStoreWithInitialValueAndSlotTrackingto the new name. - Adds a
minorchangeset for@solana/subscribabledocumenting the rename and the deprecation alias.
Things I checked:
- The deprecated alias
export type ReactiveStore<T> = ReactiveStreamStore<T>is structurally identical, so existing user code typed againstReactiveStore<T>continues to compile. - All
{@link ReactiveStore...}references I could find in the touched files have been updated; the only remainingReactiveStorementions are the deprecated alias itself and its JSDoc, which is intentional. - README narrative correctly notes the deprecated alias.
- Filename rename is consistent across source, test, and barrel import.
Minor observation, not blocking:
- The changeset only declares
@solana/subscribableas bumpingminor, but the visible API surface of@solana/rpc-subscriptions-spec(and transitively@solana/rpc-subscriptions,@solana/kit) also changed —reactive()/reactiveStore()now returnReactiveStreamStore<TNotification>. Because the publishable packages are version-locked via thefixedconfig, they'll all bump together regardless, so this isn't a release-correctness issue. Worth being aware of if anyone reads only the changeset to understand the change footprint.
LGTM from my side — leaving as a comment review since I don't have approve rights on this repo.
Contributor
|
Documentation Preview: https://kit-docs-26mc7imm7-anza-tech.vercel.app |
mcintyre94
force-pushed
the
rename-reactive-store
branch
from
4319058 to
b1fcac1
Compare
lorisleiva
approved these changes
Apr 22, 2026
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
I know I suggested ReactiveStreamStore but spending a bit more time discussing that with Claude we came across ReactiveEventStore which I think is pretty spot-on and is a better sibling to ReactiveActionStore. The latter could even become ReactiveCommandStore to really lean into the Event/Command language and give more meaning to the dispatch function. Wdyt?
Member
Author
|
@lorisleiva I slightly prefer Stream to Event, because I think Event implies append-only and access/replay to the whole event log, where our semantic (for the reactive interface) is that it's the latest data. I also slightly prefer Action because Command (to me) implies mutation, which works for |
Member
|
@mcintyre94 Ah yeah these are fair points. Stream/Action it is! |
mcintyre94
force-pushed
the
subscription-reactive-store
branch
from
57fd7dd to
330cffd
Compare
mcintyre94
force-pushed
the
rename-reactive-store
branch
from
b1fcac1 to
4e1f9d1
Compare
mcintyre94
force-pushed
the
rename-reactive-store
branch
from
4e1f9d1 to
09c9c22
Compare
mcintyre94
force-pushed
the
subscription-reactive-store
branch
from
330cffd to
a9b4199
Compare
Member
Author
Merge activity
|
mcintyre94
changed the base branch from
subscription-reactive-store
to
graphite-base/1554
mcintyre94
force-pushed
the
rename-reactive-store
branch
from
09c9c22 to
248de10
Compare
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
This was referenced May 7, 2026
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion: #1550 (comment)
We decided to rename
ReactiveStoretoReactiveStreamStore, to make space for an orthogonalReactiveActionStore.