Update to the latest ESLint and Prettier#1114
Merged
steveluscher merged 1 commit intoDec 16, 2025
Merged
Conversation
|
Contributor
Author
BundleMonUnchanged files (133)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
force-pushed
the
12-16-update_to_the_latest_eslint_and_prettier
branch
from
1a19470 to
49cbea4
Compare
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Contributor
Author
|
@lorisleiva, I think I heard you complaining about Prettier in another repo? This pr might be helpful. |
steveluscher
force-pushed
the
graphite-base/1114
branch
from
fda35c8 to
dfb2fab
Compare
steveluscher
force-pushed
the
12-16-update_to_the_latest_eslint_and_prettier
branch
from
49cbea4 to
f5e96ab
Compare
steveluscher
changed the base branch from
graphite-base/1114
to
12-16-enforce_that_any_sharedarraybuffers_passed_to_crypto_operations_get_cloned_as_non-shared
This was referenced Dec 16, 2025
steveluscher
force-pushed
the
12-16-update_to_the_latest_eslint_and_prettier
branch
from
f5e96ab to
d320734
Compare
steveluscher
force-pushed
the
12-16-enforce_that_any_sharedarraybuffers_passed_to_crypto_operations_get_cloned_as_non-shared
branch
from
dfb2fab to
ae1c4e9
Compare
steveluscher
force-pushed
the
12-16-update_to_the_latest_eslint_and_prettier
branch
2 times, most recently
from
64c455d to
e11a5d3
Compare
Contributor
Author
|
Pretty sure that documentation build error will go away once we publish a new canary from the previous PR and then update this PR to use it. |
lorisleiva
approved these changes
Dec 16, 2025
Comment on lines
+1
to
+29
| import solanaConfig from '@solana/eslint-config-solana'; | ||
| import solanaJestConfig from '@solana/eslint-config-solana/jest'; | ||
|
|
||
| export default [ | ||
| ...solanaConfig, | ||
| ...solanaJestConfig, | ||
| { | ||
| rules: { | ||
| '@typescript-eslint/no-base-to-string': 'off', | ||
| '@typescript-eslint/no-unsafe-argument': 'off', | ||
| '@typescript-eslint/no-unsafe-assignment': 'off', | ||
| '@typescript-eslint/no-unsafe-call': 'off', | ||
| '@typescript-eslint/no-unsafe-enum-comparison': 'off', | ||
| '@typescript-eslint/no-unsafe-member-access': 'off', | ||
| '@typescript-eslint/no-unsafe-return': 'off', | ||
| '@typescript-eslint/only-throw-error': 'off', | ||
| '@typescript-eslint/prefer-promise-reject-errors': 'error', | ||
| '@typescript-eslint/restrict-plus-operands': 'error', | ||
| '@typescript-eslint/restrict-template-expressions': 'error', | ||
| '@typescript-eslint/unbound-method': 'off', | ||
| 'jest/expect-expect': [ | ||
| 'error', | ||
| { | ||
| assertFunctionNames: ['expect', 'expectNewPreOffset', 'expectNewPostOffset'], | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| ]; |
Member
There was a problem hiding this comment.
Should we consider updating @solana/eslint-config-solana with these? I've been using @solana/eslint-config-solana directly lately for Codama & program repos and it would be nice if we were aligned on all these projects out-of-the-box.
Contributor
Author
There was a problem hiding this comment.
Yeah, that was totally the idea. You'll notice that most of these are 'off' and the reason for that is this: #13
The ones that ended up 'error' are, as you've noticed, just things that should have been moved into the common config.
steveluscher
force-pushed
the
12-16-enforce_that_any_sharedarraybuffers_passed_to_crypto_operations_get_cloned_as_non-shared
branch
from
ae1c4e9 to
0769816
Compare
steveluscher
force-pushed
the
12-16-update_to_the_latest_eslint_and_prettier
branch
from
e11a5d3 to
a59b071
Compare
steveluscher
changed the base branch from
12-16-enforce_that_any_sharedarraybuffers_passed_to_crypto_operations_get_cloned_as_non-shared
to
graphite-base/1114
steveluscher
force-pushed
the
12-16-update_to_the_latest_eslint_and_prettier
branch
from
a59b071 to
2d88dd5
Compare
steveluscher
force-pushed
the
graphite-base/1114
branch
from
0769816 to
109c78e
Compare
steveluscher
force-pushed
the
12-16-update_to_the_latest_eslint_and_prettier
branch
from
2d88dd5 to
8332305
Compare
steveluscher
force-pushed
the
12-16-update_to_the_latest_eslint_and_prettier
branch
from
8332305 to
95820e2
Compare
Contributor
|
Documentation Preview: https://kit-docs-4i3brt09z-anza-tech.vercel.app |
steveluscher
deleted the
12-16-update_to_the_latest_eslint_and_prettier
branch
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This stuff was all super behind, and required updating of the upstream configs, some reorganizing of how we import the
eslint.config, and some fixing of new lint violations.Test Plan