A shared method for converting Uint8Arrays to ArrayBuffers#1115
Merged
steveluscher merged 1 commit intoDec 16, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: d6e2b8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
BundleMonFiles updated (7)
Unchanged files (126)
Total files change +423B +0.11% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-qu9x3mhdh-anza-tech.vercel.app |
lorisleiva
approved these changes
Dec 16, 2025
| } else { | ||
| buffer = bytes.buffer; | ||
| } | ||
| return buffer.slice(bytesOffset, bytesOffset + bytesLength); |
Member
There was a problem hiding this comment.
Should we do that thing where we don't slice if bytesOffset === 0 && bytesLength === bytes.byteLength?
Contributor
Author
There was a problem hiding this comment.
Oh crap. I did have this thought but read somewhere that the slice is just a new view into the same data. That is obviously not true because this is not a view. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/slice
Contributor
Author
There was a problem hiding this comment.
Thing to investigate: if we do this check anywhere else, it should actually be:
(bytesOffset === 0 || bytesOffset === -bytes.byteLength)
Contributor
Author
There was a problem hiding this comment.
steveluscher
force-pushed
the
12-16-a_shared_method_for_converting_uint8arrays_to_arraybuffers_
branch
from
aeaf04e to
d6e2b8e
Compare
Contributor
Author
|
Wrote some tests. Smashing this in now. |
Contributor
Author
Merge activity
|
steveluscher
deleted the
12-16-a_shared_method_for_converting_uint8arrays_to_arraybuffers_
branch
Merged
This was referenced Dec 11, 2025
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is going to be needed in multiple places, because there are points throughout the code (ie. where
SubtleCryptooperations appear) where we will want to cast possibleSharedArrayBufferstoArrayBuffersby cloning them as non-shared.