Removes StorableAccountsWithHashes#862
Merged
mergify[bot] merged 1 commit intoanza-xyz:masterfrom Apr 17, 2024
Merged
Conversation
brooksprumo
force-pushed
the
storable-accounts/remove-storable-accounts-with-hashes
branch
2 times, most recently
from
ff43d94 to
2dc30e8
Compare
brooksprumo
force-pushed
the
storable-accounts/remove-storable-accounts-with-hashes
branch
from
2dc30e8 to
fb3aeed
Compare
brooksprumo
added
the
automerge
brooksprumo
deleted the
storable-accounts/remove-storable-accounts-with-hashes
branch
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We no longer store account hashes in storages, yet we still haul 'em around and sometimes (re)calculate them. This is unnecessary.
No one uses StorableAccountsWithHashes anymore. It can be removed.
Summary of Changes
Remove it!