Removes unused hashes params from store functions#863
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Apr 17, 2024
Merged
Conversation
brooksprumo
force-pushed
the
storable-accounts/fixup-unused-hashes-params
branch
from
47a3e5c to
9b040cf
Compare
brooksprumo
commented
Apr 17, 2024
| fn store_accounts_to<'a: 'c, 'b, 'c>( | ||
| &self, | ||
| accounts: &'c impl StorableAccounts<'b>, | ||
| _hashes: Option<Vec<impl Borrow<AccountHash>>>, |
Author
|
Requesting review early since this PR already went through CI before rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Now that we've removed account hashes as part of storing accounts, we no longer need to create/pass hashes to the various
storefunctions.Summary of Changes
Removes unused hashes params from store functions.