Skip to content

Removes hash() and has_hash() from StorableAccounts#867

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:storable-accounts/remove-hash-methods
Apr 17, 2024
Merged

Removes hash() and has_hash() from StorableAccounts#867
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:storable-accounts/remove-hash-methods

Conversation

@brooksprumo
Copy link
Copy Markdown

@brooksprumo brooksprumo commented Apr 17, 2024

Problem

We no longer store an account hash. But StorableAccounts still have hash-related functions. These are unnecessary and can be removed.

Summary of Changes

Remove the hash() and has_hash() functions on StorableAccounts.

@brooksprumo brooksprumo self-assigned this Apr 17, 2024
@brooksprumo brooksprumo force-pushed the storable-accounts/remove-hash-methods branch from 23d2003 to 4d57dd5 Compare April 17, 2024 18:55
@brooksprumo brooksprumo marked this pull request as ready for review April 17, 2024 19:34
Copy link
Copy Markdown

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brooksprumo brooksprumo merged commit da0d78c into anza-xyz:master Apr 17, 2024
@brooksprumo brooksprumo deleted the storable-accounts/remove-hash-methods branch April 17, 2024 20:41
michaelschem pushed a commit to michaelschem/agave that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants