Amend SIMD-0185#369
Merged
Benhawkins18 merged 2 commits intosolana-foundation:mainfrom Nov 7, 2025
Merged
Conversation
jstarry
commented
Sep 24, 2025
| commission or increases and before being stored in the new | ||
| `inflation_rewards_commission_bps` field. | ||
|
|
||
| #### `UpdateValidatorIdentity` |
Contributor
Author
There was a problem hiding this comment.
I added this after realizing that the validator identity might get unexpectedly out of sync with the block revenue collector after the feature gate for this SIMD is activated because there will not yet be a way for nodes to update the block revenue collector account. This sync behavior should probably be removed in #232, I will make amend that one too.
Comment on lines
+147
to
+149
| All vote instructions that previously converted deserialized vote state to v3 | ||
| MUST be updated to instead convert to v4 with the following default values for | ||
| the new fields described above: |
Contributor
Author
There was a problem hiding this comment.
I think this wording is more clear for core developers than before. Let me know if you disagree!
Contributor
There was a problem hiding this comment.
Yeah, I think this is more clear.
buffalojoec
approved these changes
Sep 24, 2025
Comment on lines
+147
to
+149
| All vote instructions that previously converted deserialized vote state to v3 | ||
| MUST be updated to instead convert to v4 with the following default values for | ||
| the new fields described above: |
Contributor
There was a problem hiding this comment.
Yeah, I think this is more clear.
topointon-jump
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.