Skip to content

faucet: deprecate run_local_faucet and run_local_faucet_with_port#7912

Merged
alexpyattaev merged 1 commit intoanza-xyz:masterfrom
puhtaytow:deprecate-local-faucet-functions
Sep 22, 2025
Merged

faucet: deprecate run_local_faucet and run_local_faucet_with_port#7912
alexpyattaev merged 1 commit intoanza-xyz:masterfrom
puhtaytow:deprecate-local-faucet-functions

Conversation

@puhtaytow
Copy link
Copy Markdown

@puhtaytow puhtaytow commented Sep 5, 2025

Problem

There is new api to be merged, making these obsolete.
Mentioned PR #7909

Summary of Changes

  • Added deprecation to run_local_faucet and run_local_faucet_with_port

@puhtaytow puhtaytow marked this pull request as draft September 5, 2025 14:37
@puhtaytow puhtaytow mentioned this pull request Sep 5, 2025
Merged
@mergify mergify Bot requested a review from a team September 5, 2025 14:37
steviez
steviez requested changes Sep 5, 2025
View reviewed changes
Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold here until #7909 (or other) finalizes

@puhtaytow puhtaytow force-pushed the deprecate-local-faucet-functions branch 2 times, most recently from 4acdc23 to 45f0264 Compare September 6, 2025 15:03
@puhtaytow puhtaytow mentioned this pull request Sep 6, 2025
Merged
@puhtaytow puhtaytow marked this pull request as ready for review September 10, 2025 11:59
@puhtaytow
Copy link
Copy Markdown
Author

puhtaytow commented Sep 10, 2025

Hold here until #7909 (or other) finalizes

🙏

@puhtaytow
Copy link
Copy Markdown
Author

puhtaytow commented Sep 15, 2025

Sorry for chasing you @steviez but just in case you forgot about this one... i have seen message at discord https://discord.com/channels/428295358100013066/439194979856809985/1416125286197760124

Not sure if we should merge this one before that cut happens 🙏 sorry if i bother you unnecessary.

steviez
steviez reviewed Sep 15, 2025
View reviewed changes
Comment thread faucet/src/faucet.rs Outdated
@steviez
Copy link
Copy Markdown

steviez commented Sep 15, 2025

Sorry for chasing you @steviez but just in case you forgot about this one... i have seen message at discord https://discord.com/channels/428295358100013066/439194979856809985/1416125286197760124

Not sure if we should merge this one before that cut happens 🙏 sorry if i bother you unnecessary.

That message is in regards to our two release branches; this commit is going into master so the message does not apply to this PR

@puhtaytow puhtaytow force-pushed the deprecate-local-faucet-functions branch from 45f0264 to a3286bb Compare September 15, 2025 17:34
@puhtaytow
Copy link
Copy Markdown
Author

puhtaytow commented Sep 15, 2025 •
edited
Loading

Sorry for chasing you @steviez but just in case you forgot about this one... i have seen message at discord https://discord.com/channels/428295358100013066/439194979856809985/1416125286197760124
Not sure if we should merge this one before that cut happens 🙏 sorry if i bother you unnecessary.

That message is in regards to our two release branches; this commit is going into master so the message does not apply to this PR

Thank you for explaining, i understood it wrongly then.

@steviez steviez added the CI Pull Request is ready to enter CI label Sep 15, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Sep 15, 2025
@puhtaytow puhtaytow force-pushed the deprecate-local-faucet-functions branch 2 times, most recently from b8d62df to c7f4f6a Compare September 16, 2025 15:31
@puhtaytow
Copy link
Copy Markdown
Author

puhtaytow commented Sep 16, 2025 •
edited
Loading

Hey @steviez CI was angry so I had to slap allow use of deprecated on faucet/run_local_faucet_with_port and it revealed as well issue with validator/bin/solana-test-validator, using the soon-deprecated test helpers.

The later concerns me a bit, i wanted to migrate it to the new faucet api, but the new api is behind DCOU.
Would you suggest other solution than allow use deprecated there as well, or just omitt faucet helper at all?

--edit
Here the PR which omitt the helper at all #8068

@puhtaytow puhtaytow mentioned this pull request Sep 16, 2025
Merged
@puhtaytow puhtaytow force-pushed the deprecate-local-faucet-functions branch from 0880a0a to c7f4f6a Compare September 16, 2025 16:30
@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Sep 18, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Sep 18, 2025
@alexpyattaev
Copy link
Copy Markdown

alexpyattaev commented Sep 18, 2025

Thank you @puhtaytow this looks appropriate, we definitely do not want people accidentally booking random ports.

@alexpyattaev alexpyattaev self-requested a review September 18, 2025 21:29
@puhtaytow
Copy link
Copy Markdown
Author

puhtaytow commented Sep 19, 2025

Thank you @puhtaytow this looks appropriate, we definitely do not want people accidentally booking random ports.

Indeed.. we just have to merge this one before #8068 so CI stop being angry.
Thank you 🙏

KirillLykov pushed a commit that referenced this pull request Sep 21, 2025
@puhtaytow
validator: ditch call to old faucet test api in solana test validator (…
ad0c19f 
…#8068)

The solana-test-validator in validator package calls old faucet test api, which we want to deprecate in #7912
In this PR, solana-test-validator spawn local faucet directly, omitting the (deprecated soon) faucet test helper function.
@puhtaytow puhtaytow force-pushed the deprecate-local-faucet-functions branch from c7f4f6a to cef4951 Compare September 21, 2025 15:12
@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Sep 22, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Sep 22, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.9%. Comparing base (ad0c19f) to head (cef4951).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #7912     +/-   ##
=========================================
- Coverage    82.9%    82.9%   -0.1%     
=========================================
  Files         823      823             
  Lines      361216   361217      +1     
=========================================
- Hits       299780   299772      -8     
- Misses      61436    61445      +9
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexpyattaev alexpyattaev merged commit fd1c7aa into anza-xyz:master Sep 22, 2025
45 checks passed
@puhtaytow
Copy link
Copy Markdown
Author

puhtaytow commented Sep 22, 2025

Thank you 🙏

@puhtaytow puhtaytow deleted the deprecate-local-faucet-functions branch September 22, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steviez steviez steviez approved these changes

@alexpyattaev alexpyattaev alexpyattaev approved these changes

Assignees

No one assigned

Labels

community need:merge-assist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@puhtaytow @steviez @alexpyattaev @codecov-commenter @anza-team