run local faucet with non-overlapping ports behind test/debug gate

[puhtaytow]

Problem

Tests which engage ports binding are still randomly flaky.
While looking for source of the evil, i found that test_bench_tps_test_validator calls run_local_faucet which takes a port randomly.

This isn't correct behaviour as the randomly picked port might overlap with one of ports allocated thru unique_port_range_for_tests

Summary of Changes

• Now, the run_local_faucet, Takes non-overlapping port for debug_assertions. Otherwise defaults to random port as before.

[alexpyattaev]

I think a better gate to use is debug_assertions. Using NEXTEST here will still allow this to break if running under plain cargo test.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.1%. Comparing base (0c3bf69) to head (51c94f3).

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #7736     +/-   ##
=========================================
- Coverage    83.1%    83.1%   -0.1%     
=========================================
  Files         808      808             
  Lines      356469   356479     +10     
=========================================
- Hits       296288   296270     -18     
- Misses      60181    60209     +28     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[alexpyattaev]

This looks good

[puhtaytow]

This looks good

Thank you 🙏

[gregcusack]

lgtm! thank you!

[gregcusack]

looks like this PR created this warning when compiling master with --release:

$ cargo build --release
warning: gen-syscall-list@3.1.0: (not a warning) Generating ../../platform-tools-sdk/sbf/syscalls.txt from ../src/lib.rs
warning: unused import: `solana_net_utils::sockets::unique_port_range_for_tests`
  --> faucet/src/faucet.rs:18:5
   |
18 |     solana_net_utils::sockets::unique_port_range_for_tests,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

any chance you could fix if you have time please? @puhtaytow

[alexpyattaev]

looks like this PR created this warning when compiling master with --release:

We need to check for warnings in release builds in CI. It is by far not the first time these things slip by, impossible to catch them by hand every time.

[puhtaytow]

looks like this PR created this warning when compiling master with --release:

$ cargo build --release
warning: gen-syscall-list@3.1.0: (not a warning) Generating ../../platform-tools-sdk/sbf/syscalls.txt from ../src/lib.rs
warning: unused import: `solana_net_utils::sockets::unique_port_range_for_tests`
  --> faucet/src/faucet.rs:18:5
   |
18 |     solana_net_utils::sockets::unique_port_range_for_tests,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

any chance you could fix if you have time please? @puhtaytow

@gregcusack Sorry, I totally didn't think about it here is the fix #7847