resolve issue with local faucet overlapping ports in tests / new api

[puhtaytow]

Problem

Tests which engage ports binding are still randomly flaky.
While looking for source of the evil, i found that test_bench_tps_test_validator calls run_local_faucet which takes a port randomly.

This isn't correct behaviour as the randomly picked port might overlap with one of ports allocated thru unique_port_range_for_tests

Originally resolved #7736 then reverted and the alternate PR is here, as suggested in #7736 (comment)

Summary of Changes

• New API in faucet has been introduced:

  • run_local_faucet_with_unique_port_for_tests
  • run_local_faucet_with_config
  • run_local_faucet_for_tests
  • LocalFaucetConfig

• Benchmarks has been migrated:

  • solana-accounts-cluster-bench
  • solana-bench-tps

• Tests has been migrated:

  • solana-faucet
  • solana-dos
  • solana-cli

[puhtaytow]

I see that CI failed due to...

`dev-context-only-utils` must not be used as normal dependencies, but is by "([crate]: [dependency])":
    solana-cli: solana-faucet
🚨 Error: The command exited with status 1

which didn't happen by running locally /ci/test-checks.sh and more importantly, not sure what to do with it now.

--- edit
maybe cli/src/test_utils should be moved somewhere else?

[kskalski]

I guess you will see error when running
scripts/check-dev-context-only-utils.sh tree

Did you try adding separate dependency and dev-dependency, where only dev-dependency has feature DCOU set? I.e. this line in cli/Cargo.toml seems to be a problem:

solana-faucet = { workspace = true, features = ["dev-context-only-utils"] }

[steviez]

Just one last minor thing and think we're good then

[alexpyattaev]

LGTM

[puhtaytow]

Thank you guys! :)