faucet: put unique port range for tests behind debug_assertions gate#7847
Closed
puhtaytow wants to merge 1 commit intoanza-xyz:masterfrom
Closed
faucet: put unique port range for tests behind debug_assertions gate#7847puhtaytow wants to merge 1 commit intoanza-xyz:masterfrom
puhtaytow wants to merge 1 commit intoanza-xyz:masterfrom
Conversation
alexpyattaev
reviewed
Sep 3, 2025
puhtaytow
force-pushed
the
fix-unused-import-in-release-build-faucet
branch
from
f639519 to
90ce42f
Compare
puhtaytow
force-pushed
the
fix-unused-import-in-release-build-faucet
branch
from
90ce42f to
c6928d6
Compare
|
@gregcusack are you happy with this fix? |
gregcusack
approved these changes
Sep 3, 2025
gregcusack
left a comment
gregcusack
left a comment
There was a problem hiding this comment.
lgtm! but would wait for steve review to make sure he is in fact ok with this in line gating
Author
|
thank you guys for the review 🙏 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7847 +/- ##
=======================================
Coverage 83.0% 83.1%
=======================================
Files 809 809
Lines 356483 356483
=======================================
+ Hits 296203 296244 +41
+ Misses 60280 60239 -41 🚀 New features to boost your workflow:
|
steviez
requested changes
Sep 4, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Let's all agree on a way forward in: #7736 (comment)
My latest rec. was to back out that PR, so if we go that way we should avoid adding a commit that is on top of the commit that we'd be backing out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The #7736 had missing gate for import used only in
debug_assertionscase, causing warning in release builds.Summary of Changes
As suggested here #7736 (comment)
Now its properly gated.