forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 1k
geyser: update to ReplicaAccountInfoV4 #6520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jstarry
wants to merge
2
commits into
anza-xyz:master
Choose a base branch
from
jstarry:geyser-account-v4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned with such changes removing fields for the transaction. For plugins relying on this, they would need to make large changes to look up. ReplicaTransactionInfoV3 already exposes SanitizedTransaction so this change little facts on the encapsulation side. Also, SanitizedTransaction is not exactly internal as it is declared in the SDK. I think we should address them comprehensively in a new breaking change for interfaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean. You reviewed #6515 which removes
SanitizedTransactionfromReplicaTransactionInfoV3in favor of usingVersionedTransaction.Unfortunately many internal types have been added to the SDK and we are trying to clean that up.
SanitizedTransactioncannot be used for transactions that fail account resolution so we need to migrate away from using that type.Yes, they will need to migrate when they upgrade to agave v3 which is an appropriate time to make such breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant removing the transaction and forcing the current plugin to the additional lookup. I am okay to change to VersionedTransaction here as well. I would be easier for the plugin to change to integrate the new changes. Otherwise, they would have to cache the transaction changes or do additional lookup in the database. Some plugin may not even subscribe to the transaction interface and solely depends on this interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm ok with switching to
VersionedTransactionhere but I don't think it's the best idea because unlike transaction updates, we wouldn't have any transaction metadata like resolved lookup table addressesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You meant it did not have TransactionStatusMeta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, exactly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The earlier account updater interface did not have TransactionStatusMeta either. Can one still make use of the message in it?