SIMD-0192: Relax Transaction Constraints - Account Resolution#192
SIMD-0192: Relax Transaction Constraints - Account Resolution#192apfitzge wants to merge 5 commits intosolana-foundation:mainfrom
Conversation
04f3dd3 to
7ed2ca5
Compare
|
I like the idea!
This one gives me a bit of pause because of the potential race between extending an address lookup table and using the new indices. Right now, the warmup is only one slot, which means the following scenario is possible:
This isn't horrible, and the user can deal with it in several ways (resigning and re-sending I just think this case needs to be thought out a bit. |
It's a good point, but I don't view the case as substantially different than the race between any state on Solana wrt fork changes. |
7ed2ca5 to
21659ec
Compare
|
|
||
| The current protocol requires that the the account keys used in a transaction: | ||
|
|
||
| 1. Contain no duplicate account keys, |
There was a problem hiding this comment.
If a transaction includes a key twice, does it get charged for the write lock once or twice?
There was a problem hiding this comment.
Clarified below - account key values are not considered for transaction-cost calculation, just the number of write locks requested.
Transactions violating the constraints are treated the same as "fee-only" transactions are currently for the cost-model.
|
This one looks really powerful. It means every submitted transaction even if it fails due to invalid lookups or stale nonces will still pay and advance state, introducing a real economic floor. |
| Such transactions must have transaction costs for block-limits applied only | ||
| to the fee-payer and nonce accounts, since execution will not even be | ||
| attempted. |
There was a problem hiding this comment.
This is definitely a corner case, but we should probably specify it: if the fee payer and nonce accounts are duplicates of each other, does the write lock cost get applied once or twice?
Once makes more sense, but requires an extra check. Twice is more natural from an implementation perspective. I think either is fine, but it just needs to be specified.
There was a problem hiding this comment.
Sorry for (very) slow response! If the nonce & fee-payer are the same acct, write lock costs are applied once, as is the case today. Nonce is just a reference to an acct index like any other, so this feels the most straight-forward imo.
There was a problem hiding this comment.
3fb21b1 LMK if this added sentence is clear.
|
Hey @apfitzge, this PR has been inactive for 60 days and is now marked as stale. If you're still working on this, please comment below to let us know. Otherwise, this PR will be automatically closed in 7 days. To keep this PR active, simply leave a comment explaining the current status or any blockers you're facing. |
|
Hey @apfitzge, this PR has been automatically closed due to inactivity. The PR was marked as stale 7 days ago and there was no response from the author. If you'd like to continue working on this, feel free to reopen the PR and leave a comment with an update on its status. |
No description provided.