geyser: update to ReplicaTransactionInfoV3#6515
Conversation
| #[repr(C)] | ||
| pub struct ReplicaTransactionInfoV3<'a> { | ||
| /// The transaction message hash, used for identifying the transaction. | ||
| pub message_hash: &'a Hash, |
There was a problem hiding this comment.
I changed this from signature to message_hash because the message hash used to only be available from the SanitizedTransaction and because you can get the tx signature from the VersionedTransaction
There was a problem hiding this comment.
To keep the interface more stable, I think it would be simpler for the plugin update by keeping the signature field which is reference. And add this new message_hash.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6515 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 847 847
Lines 379700 379708 +8
=========================================
- Hits 314697 314488 -209
- Misses 65003 65220 +217 🚀 New features to boost your workflow:
|
tao-stones
left a comment
There was a problem hiding this comment.
Motivation and implementation both look good to me. I'll defer to @lijunwangs at the finer points.
Problem
SanitizedTransactionis a runtime type that should have never been exposed to end users via sdk or geyser. Also, in order to implement SIMD-0192, we will need to be able to commit transactions which cannot be represented asSanitizedTransaction's due to address lookup failures.Summary of Changes
Introduce a new version (v3) of geyser transaction info using
VersionedTransactioninstead ofSanitizedTransactionFixes #