v2.2: bump cargo sort to v2#6582
Merged
steviez merged 2 commits intoanza-xyz:v2.2from Jun 19, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.2 #6582 +/- ##
========================================
Coverage 83.3% 83.4%
========================================
Files 807 807
Lines 373498 373498
========================================
+ Hits 311471 311624 +153
+ Misses 62027 61874 -153 🚀 New features to boost your workflow:
|
steviez
reviewed
Jun 13, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
I think we should probably hold off on the v2.2 version of this until we get crates building on the branch again. We might need to BP some of the use-individual-sdk-crate changes, and this would assuredly create merge conflicts with that
steviez
approved these changes
Jun 18, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
LGTM and confirmed just the version bump + all Cargo.toml changes
| # cargo install cargo-hack && \ | ||
| cargo install --git https://github.com/anza-xyz/cargo-hack.git --rev 5e59c3ec6c661c02601487c0d4b2a2649fe06c9f cargo-hack && \ | ||
| cargo install cargo-sort && \ | ||
| cargo install cargo-sort@^2 && \ |
t-nelson
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
we use bump cargo sort to v2 on master: #6406. the inconsistent versions in v2.2 and v2.3 will make backporting very painful
Summary of Changes
./scripts/cargo-for-all-lock-files.sh -- sort --workspace