v2.3: bump cargo sort to v2#6583
Conversation
|
Was there a reason for not just applying the |
|
I guess we must have some conflicts here, so just do it separately. 🫠 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.3 #6583 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 848 848
Lines 379552 379552
=========================================
- Hits 314532 314522 -10
- Misses 65020 65030 +10 🚀 New features to boost your workflow:
|
I just tried it and 3 files conflicted. The pros of the BP label is that I can "lean more heavily" on the initial review, although that also somewhat assumes that someone diligently looked at the initial one. We can probably trust the automation on this one; I'll skim this with fresh eyes in the morning |
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Hopefully our rate of BP PR's and people needing to actively develop on this branch declines, but should help reduce some friction so I'm good with it
| # cargo install cargo-hack && \ | ||
| cargo install --git https://github.com/anza-xyz/cargo-hack.git --rev 5e59c3ec6c661c02601487c0d4b2a2649fe06c9f cargo-hack && \ | ||
| cargo install cargo-sort && \ | ||
| cargo install cargo-sort@^2 && \ |
There was a problem hiding this comment.
Confirmed that this is the only non Cargo.toml change
4 participants
Problem
we use bump cargo sort to v2 on master: #6406. the inconsistent versions in v2.2 and v2.3 will make backporting very painful
Summary of Changes
./scripts/cargo-for-all-lock-files.sh -- sort --workspace