Skip to content

remove dependency on solana-feature-set-interface#5549

Merged
t-nelson merged 1 commit intoanza-xyz:masterfrom
t-nelson:itwasamistake
Mar 27, 2025
Merged

remove dependency on solana-feature-set-interface#5549
t-nelson merged 1 commit intoanza-xyz:masterfrom
t-nelson:itwasamistake

Conversation

@t-nelson
Copy link
Copy Markdown

Problem

we thought it would be nice to have a common feature set interface between sdk and monorepo. we were wrong

Summary of Changes

removes all use of solana-feature-set-interface

@t-nelson t-nelson requested review from joncinque and jstarry March 27, 2025 20:17
@t-nelson
Copy link
Copy Markdown
Author

if we're quick, we can just delete the crate like none of this ever happened

https://crates.io/crates/solana-feature-set-interface/reverse_dependencies

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (2f4e86a) to head (eee185e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5549   +/-   ##
=======================================
  Coverage    83.3%    83.3%           
=======================================
  Files         827      827           
  Lines      373444   373435    -9     
=======================================
+ Hits       311341   311422   +81     
+ Misses      62103    62013   -90     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-nelson t-nelson merged commit 359d7eb into anza-xyz:master Mar 27, 2025
58 checks passed
@t-nelson t-nelson deleted the itwasamistake branch March 27, 2025 23:01
@t-nelson t-nelson added the v2.2 label Apr 12, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 12, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify Bot pushed a commit that referenced this pull request Apr 12, 2025
(cherry picked from commit 359d7eb)

# Conflicts:
#	Cargo.toml
t-nelson added a commit that referenced this pull request Apr 12, 2025
(cherry picked from commit 359d7eb)

# Conflicts:
#	Cargo.toml
t-nelson added a commit that referenced this pull request Apr 14, 2025
…5549) (#5788)

remove dependency on solana-feature-set-interface (#5549)

(cherry picked from commit 359d7eb)

# Conflicts:
#	Cargo.toml

Co-authored-by: Trent Nelson <490004+t-nelson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants