v2.2: move version pinning to binary crates for sdk deps (backport of #5594)#5783
v2.2: move version pinning to binary crates for sdk deps (backport of #5594)#5783
Conversation
|
Cherry-pick of 0a0cce2 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
81eac0c to
3e3af8a
Compare
|
@mergify rebase |
☑️ Nothing to doDetails
|
* move version pinning to binary crates for sdk deps * address review (cherry picked from commit 0a0cce2)
3e3af8a to
f3a51e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.2 #5783 +/- ##
=========================================
- Coverage 83.4% 83.4% -0.1%
=========================================
Files 806 806
Lines 373256 373256
=========================================
- Hits 311351 311342 -9
- Misses 61905 61914 +9 🚀 New features to boost your workflow:
|
| solana-ed25519-program = "=2.2.2" | ||
| solana-ed25519-program = "2.2.2" | ||
| solana-entry = { path = "entry", version = "=2.2.9" } | ||
| solana-feature-set-interface = "=4.0.0" |
There was a problem hiding this comment.
This should probably get relaxed too
There was a problem hiding this comment.
i skipped this one on purpose. was going to bp #5549 instead
There was a problem hiding this comment.
I didn't catch this last time, but this crate isn't actually a binary crate. the solana-test-validator binary is built from the validator crate, so we likely don't need to pin here
There was a problem hiding this comment.
ah ok. let's unwind that in master and bp separately
| solana-message = "=2.2.1" | ||
| solana-pubkey = { version = "=2.2.1", default-features = false } | ||
| solana-rpc-client = { workspace = true } | ||
| solana-sha256-hasher = { workspace = true } |
There was a problem hiding this comment.
I missed this last time, but this crate comes from the SDK and should be pinned
There was a problem hiding this comment.
yeah, the wip robot noticed too 😅
These crates have the wrong version in '/scratch/code/solana/solana/install/Cargo.toml':
solana-sha256-hasher: has 'workspace' but expected '=2.2.1'
will fix this one in master and bp separately as well
joncinque
left a comment
There was a problem hiding this comment.
Sounds like everything I brought up will get addressed separately, so ![]()
Problem
version pinning in the monorepo restricts dependency options for the remaining public api crates that reside there
eg. try to use
solana-client = "2.2.1"(monorepo) withsolana-transaction = "2.2.2"(sdk)Summary of Changes
move all version pinning from workspace to bin crates for sdk dependencies
This is an automatic backport of pull request #5594 done by Mergify.