Skip to content

v2.2: remove dependency on solana-feature-set-interface (backport of #5549)#5788

Merged
t-nelson merged 1 commit intov2.2from
mergify/bp/v2.2/pr-5549
Apr 14, 2025
Merged

v2.2: remove dependency on solana-feature-set-interface (backport of #5549)#5788
t-nelson merged 1 commit intov2.2from
mergify/bp/v2.2/pr-5549

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Apr 12, 2025

Problem

we thought it would be nice to have a common feature set interface between sdk and monorepo. we were wrong

Summary of Changes

removes all use of solana-feature-set-interface


This is an automatic backport of pull request #5549 done by Mergify.

@mergify mergify Bot requested a review from a team as a code owner April 12, 2025 15:07
@mergify mergify Bot added the conflicts label Apr 12, 2025
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Apr 12, 2025

Cherry-pick of 359d7eb has failed:

On branch mergify/bp/v2.2/pr-5549
Your branch is up to date with 'origin/v2.2'.

You are currently cherry-picking commit 359d7eb2b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Cargo.lock
	modified:   feature-set/Cargo.toml
	modified:   feature-set/src/lib.rs
	modified:   programs/sbf/Cargo.lock
	modified:   svm/examples/Cargo.lock

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Cargo.toml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

(cherry picked from commit 359d7eb)

# Conflicts:
#	Cargo.toml
@t-nelson t-nelson force-pushed the mergify/bp/v2.2/pr-5549 branch from b57b288 to 8c371bb Compare April 12, 2025 16:54
@t-nelson t-nelson requested review from joncinque and jstarry April 12, 2025 16:54
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.4%. Comparing base (52fbd17) to head (8c371bb).

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.2    #5788   +/-   ##
=======================================
  Coverage    83.4%    83.4%           
=======================================
  Files         806      806           
  Lines      373256   373247    -9     
=======================================
+ Hits       311314   311365   +51     
+ Misses      61942    61882   -60     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-nelson t-nelson merged commit a74b13a into v2.2 Apr 14, 2025
46 checks passed
@t-nelson t-nelson deleted the mergify/bp/v2.2/pr-5549 branch April 14, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants