Skip to content

v2.1: Feature - Lift CPI Caller Restriction (backport of #2202)#3500

Closed
mergify[bot] wants to merge 2 commits into
v2.1from
mergify/bp/v2.1/pr-2202
Closed

v2.1: Feature - Lift CPI Caller Restriction (backport of #2202)#3500
mergify[bot] wants to merge 2 commits into
v2.1from
mergify/bp/v2.1/pr-2202

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Nov 6, 2024

See SIMD-0163


This is an automatic backport of pull request #2202 done by Mergify.

@mergify mergify Bot requested a review from a team as a code owner November 6, 2024 12:12
@mergify mergify Bot added the conflicts label Nov 6, 2024
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Nov 6, 2024

Cherry-pick of 228d3b3 has failed:

On branch mergify/bp/v2.1/pr-2202
Your branch is up to date with 'origin/v2.1'.

You are currently cherry-picking commit 228d3b3427.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   programs/sbf/tests/programs.rs
	modified:   runtime/src/bank/tests.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   program-runtime/src/invoke_context.rs
	both modified:   sdk/feature-set/src/lib.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot assigned Lichtso Nov 6, 2024
@Lichtso Lichtso force-pushed the mergify/bp/v2.1/pr-2202 branch from 4a17631 to f2b339e Compare November 20, 2024 17:20
* Adds the feature.

* Adds the feature gate logic.

* Adjusts tests.

* Adds deprecation attributes.

* Set is_executable flag upon initialization in loader-v4.

(cherry picked from commit 3bf9c2e)
* Adds the feature.

* Adds the feature gate logic.

* Adjusts tests.

(cherry picked from commit 228d3b3)
@Lichtso Lichtso force-pushed the mergify/bp/v2.1/pr-2202 branch from f2b339e to 7fbbd7e Compare November 21, 2024 17:16
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Nov 21, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@bw-solana
Copy link
Copy Markdown

Argument for backporting is that it allows for cheaper CPIs, which effectively increases blockspace

@Lichtso Lichtso closed this Jan 10, 2025
@steviez steviez deleted the mergify/bp/v2.1/pr-2202 branch June 5, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants