Skip to content

v2.1: Feature - Remove accounts executable flag checks (backport of #2182)#3470

Closed
mergify[bot] wants to merge 1 commit into
v2.1from
mergify/bp/v2.1/pr-2182
Closed

v2.1: Feature - Remove accounts executable flag checks (backport of #2182)#3470
mergify[bot] wants to merge 1 commit into
v2.1from
mergify/bp/v2.1/pr-2182

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Nov 4, 2024

See SIMD-0162


This is an automatic backport of pull request #2182 done by Mergify.

@mergify mergify Bot requested a review from a team as a code owner November 4, 2024 21:13
@mergify mergify Bot assigned Lichtso Nov 4, 2024
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Nov 4, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso requested a review from HaoranYi November 4, 2024 21:18
HaoranYi
HaoranYi previously approved these changes Nov 4, 2024
Copy link
Copy Markdown

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

* Adds the feature.

* Adds the feature gate logic.

* Adjusts tests.

* Adds deprecation attributes.

* Set is_executable flag upon initialization in loader-v4.

(cherry picked from commit 3bf9c2e)
@Lichtso Lichtso force-pushed the mergify/bp/v2.1/pr-2182 branch from c968c45 to fecac47 Compare November 21, 2024 17:12
Copy link
Copy Markdown

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bw-solana
Copy link
Copy Markdown

Argument for backporting this is because it builds the base for #3500 , which we want to backport

@Lichtso Lichtso closed this Jan 10, 2025
@steviez steviez deleted the mergify/bp/v2.1/pr-2182 branch June 5, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants