Skip to content

Feature - Lift CPI Caller Restriction#2202

Merged
Lichtso merged 3 commits into
anza-xyz:masterfrom
Lichtso:feature/lift_cpi_caller_restriction
Nov 6, 2024
Merged

Feature - Lift CPI Caller Restriction#2202
Lichtso merged 3 commits into
anza-xyz:masterfrom
Lichtso:feature/lift_cpi_caller_restriction

Conversation

@Lichtso
Copy link
Copy Markdown

@Lichtso Lichtso commented Jul 19, 2024

See SIMD-0163

@Lichtso Lichtso force-pushed the feature/lift_cpi_caller_restriction branch 2 times, most recently from cb89509 to 762c8ee Compare July 24, 2024 11:18
@Lichtso Lichtso force-pushed the feature/lift_cpi_caller_restriction branch 2 times, most recently from 71d4ba8 to 8f8b180 Compare August 5, 2024 07:35
@mergify
Copy link
Copy Markdown

mergify Bot commented Aug 9, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the feature/lift_cpi_caller_restriction branch from 8f8b180 to 1713978 Compare November 4, 2024 21:32
@Lichtso Lichtso marked this pull request as ready for review November 4, 2024 21:34
@Lichtso Lichtso added the v2.1 label Nov 4, 2024
@mergify
Copy link
Copy Markdown

mergify Bot commented Nov 4, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@Lichtso Lichtso requested a review from pgarg66 November 4, 2024 21:41
@Lichtso Lichtso merged commit 228d3b3 into anza-xyz:master Nov 6, 2024
@Lichtso Lichtso deleted the feature/lift_cpi_caller_restriction branch November 6, 2024 12:10
mergify Bot pushed a commit that referenced this pull request Nov 6, 2024
* Adds the feature.

* Adds the feature gate logic.

* Adjusts tests.

(cherry picked from commit 228d3b3)

# Conflicts:
#	program-runtime/src/invoke_context.rs
#	sdk/feature-set/src/lib.rs
Lichtso added a commit that referenced this pull request Nov 21, 2024
* Adds the feature.

* Adds the feature gate logic.

* Adjusts tests.

(cherry picked from commit 228d3b3)
yufeng-jump added a commit to firedancer-io/firedancer that referenced this pull request Feb 10, 2025
This mirrors anza-xyz/agave#2202

Also gate account executable check in cpi prepare_instruction behind
the remove_accounts_executable_flag_checks flag.
yufeng-jump added a commit to firedancer-io/firedancer that referenced this pull request Feb 10, 2025
This mirrors anza-xyz/agave#2202

Also gate account executable check in cpi prepare_instruction behind
the remove_accounts_executable_flag_checks flag.
yufeng-jump added a commit to firedancer-io/firedancer that referenced this pull request Feb 11, 2025
This mirrors anza-xyz/agave#2202

Also gate account executable check in cpi prepare_instruction behind
the remove_accounts_executable_flag_checks flag.
github-merge-queue Bot pushed a commit to firedancer-io/firedancer that referenced this pull request Feb 13, 2025
This mirrors anza-xyz/agave#2202

Also gate account executable check in cpi prepare_instruction behind
the remove_accounts_executable_flag_checks flag.
yufeng-jump added a commit to firedancer-io/firedancer that referenced this pull request Feb 13, 2025
This mirrors anza-xyz/agave#2202

Also gate account executable check in cpi prepare_instruction behind
the remove_accounts_executable_flag_checks flag.
yufeng-jump added a commit to firedancer-io/firedancer that referenced this pull request Feb 13, 2025
This mirrors anza-xyz/agave#2202

Also gate account executable check in cpi prepare_instruction behind
the remove_accounts_executable_flag_checks flag.
yufeng-jump added a commit to firedancer-io/firedancer that referenced this pull request Feb 13, 2025
This mirrors anza-xyz/agave#2202

Also gate account executable check in cpi prepare_instruction behind
the remove_accounts_executable_flag_checks flag.
github-merge-queue Bot pushed a commit to firedancer-io/firedancer that referenced this pull request Feb 13, 2025
This mirrors anza-xyz/agave#2202

Also gate account executable check in cpi prepare_instruction behind
the remove_accounts_executable_flag_checks flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants