switch to solana-tpu-client from solana_client::tpu_client for bench-tps, dos/, LocalCluster, gossip/

[gregcusack]

A Followup PR to: #258. Removes dependency on solana_client::tpu_client and switches over to solana-tpu-client.

Problem

We may end up removing solana_client::tpu_client and the other associated wrappers in solana_client. So switching the dependency bench-tps, dos/, LocalCluster, gossip/ from solana_client::tpu_client to solana_tpu_client.

This is the 9th PR on the way to remove ThinClient completely.
See

• 1st PR: change default bench-tps client to tpu-client solana-labs/solana#35335
• 2nd PR: Deprecate ThinClient and remove ThinClient from bench-tps solana-labs/solana#35365
• 3rd PR: deprecate get_client and get_multi_client #177
• 4th PR: bump deprecated version numbers for get_client and get_multi_client #184
• 5th PR: Remove ThinClient from dos/ #117
• 6th PR: Fully remove ThinClient from bench-tps #132
• 7th PR: update changelog and remove deprecated label on gossip_service::get_client() #227
• 8th PR: add in method for building a TpuClient for LocalCluster tests #258

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (8df80d9) to head (28e09bb).
Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master     #310     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         837      837             
  Lines      226896   226896             
=========================================
- Hits       185901   185900      -1     
- Misses      40995    40996      +1     

[CriesofCarrots]

Definitely support :) Just one objection and a couple questions about dependencies.

[CriesofCarrots]

I'd like to avoid adding either of these dependencies to solana-tpu-client, so that downstream users don't have to import both by default if they only need one. I know you're trying to dedupe things (based on a reviewer request), but I think defining QuicTpuClient and TpuClientWrapper at the call sites or at least further upstream would be better.

[gregcusack]

QuicTpuClient can be rearranged easily. TpuClientWrapper is a little harder. We could define it in gossip_service and then have dos import it along with gossip/. Although this requires gossip to import solana-udp-client and solana-quic-client. The other option I see is we put it back up in solana-client as before since solana-client is imported by gossip_service and dos anyway. But then this has the issue that we are now back to relying on solana-client::tpu_client...

[gregcusack]

so I put TpuClientWrapper back in solana_client since gossip and dos are already importing solana_client anyway. I know it is not ideal. I also tried putting it in gossip but didn't like that we had to import solana-udp-client and solana-quic-client in gossip just for that wrapper. But if that is not a big deal, then lets add it in gossip. Couldn't find another spot further upstream either that made sense.

[CriesofCarrots]

but didn't like that we had to import solana-udp-client and solana-quic-client in gossip just for that wrapper

To be clear, the fact that solana-gossip imports solana-client means it is already importing solana-udp-client and solana-quic-client transitively. At some point it will actually be better to have it import one or both of those directly. But since it's still stuck on solana_client::connection_cache::ConnectionCache, this seems fine for now.

[gregcusack]

oh shoot ya that's a good point. I should have realized that 🤦‍♂️. ok sounds good. Thank you!

[CriesofCarrots]

Thanks for the rearrangement! Sorry that each one of these points to more cleanup to be done 😅
Lgtm!