update changelog and remove deprecated label on gossip_service::get_client()#227
Merged
gregcusack merged 1 commit intoanza-xyz:masterfrom Mar 13, 2024
Conversation
42bfd18 to
a8928d5
Compare
This was referenced Mar 14, 2024
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
…client()` (anza-xyz#227) update changelog and remove deprecated label on get_client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7th PR on the way to remove
ThinClientcompletely.See
bench-tpsclient totpu-clientsolana-labs/solana#35335ThinClientand removeThinClientfrombench-tpssolana-labs/solana#35365get_clientandget_multi_client#177get_clientandget_multi_client#184ThinClientfromdos/#117ThinClientfrombench-tps#132Problem
added breaking changes in PR: #117, so need to update changelog
Summary of Changes
gossip_service::get_client()deprecatedtag