Skip to content

bpf_loader: remove ExtendProgramChecked instruction#11685

Merged
buffalojoec merged 2 commits into
anza-xyz:masterfrom
buffalojoec:bpf-loader-delete-extend-program-checked
Apr 10, 2026
Merged

bpf_loader: remove ExtendProgramChecked instruction#11685
buffalojoec merged 2 commits into
anza-xyz:masterfrom
buffalojoec:bpf-loader-delete-extend-program-checked

Conversation

@buffalojoec
Copy link
Copy Markdown

@buffalojoec buffalojoec commented Apr 1, 2026

Problem

SIMD-0164 was closed and never landed. Therefore the ExtendProgramChecked instruction should not exist.

Summary of Changes

Remove it from the Loader V3 program as well as the CLI.

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 1, 2026

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (ed322a9) to head (0c44852).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #11685    +/-   ##
========================================
  Coverage    83.1%    83.2%            
========================================
  Files         860      860            
  Lines      321462   321349   -113     
========================================
- Hits       267408   267368    -40     
+ Misses      54054    53981    -73     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Lichtso
Lichtso previously approved these changes Apr 9, 2026
@Lichtso
Copy link
Copy Markdown

Lichtso commented Apr 9, 2026

Think it is small enough to land in one go.

@buffalojoec
Copy link
Copy Markdown
Author

Think it is small enough to land in one go.

Actually let me break it up, because I decided to keep the test module and already broke off the CLI bit: #11764

@buffalojoec buffalojoec force-pushed the bpf-loader-delete-extend-program-checked branch from 7370dd3 to 0c44852 Compare April 10, 2026 04:10
@buffalojoec buffalojoec marked this pull request as ready for review April 10, 2026 04:23
@buffalojoec buffalojoec requested a review from a team as a code owner April 10, 2026 04:23
@buffalojoec
Copy link
Copy Markdown
Author

@Lichtso this PR is now based on #11764. If you still think it's good to land as-is, I'll just merge this and close #11764.

Signal with approval. 😄

@buffalojoec buffalojoec added this pull request to the merge queue Apr 10, 2026
Merged via the queue into anza-xyz:master with commit a5185b6 Apr 10, 2026
48 checks passed
@buffalojoec buffalojoec deleted the bpf-loader-delete-extend-program-checked branch April 10, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants