SIMD-0431: Loader V3: Minimum Extend Program Size#9859
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
ab2ac67 to
d4abd85
Compare
joncinque
left a comment
There was a problem hiding this comment.
The program change and tests look great!
The CI failures look legit, since they're from CLI tests that extend programs. Most likely those tests are using numbers that are too small.
Yeah, whoops I forgot I'd also have to handle the CLI in this same change. Added one more commit for that! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9859 +/- ##
=========================================
- Coverage 83.1% 83.1% -0.1%
=========================================
Files 861 861
Lines 322079 322122 +43
=========================================
- Hits 267922 267865 -57
- Misses 54157 54257 +100 🚀 New features to boost your workflow:
|
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just the tiny nit on the error, but you can take it or leave it
joncinque
left a comment
There was a problem hiding this comment.
Looks good, just a merge conflict now
330f353 to
0dbe912
Compare
|
Sorry @joncinque I had to rebase onto #11685. Also @Lichtso need SVM approval for merge. |
Problem
SIMD-0431 adds a minimum size requirement to the Loader V3 program. The program must be updated to enforce this check once the feature is enabled.
Summary of Changes
Implements SIMD-0431 by adding a check for the extension size's minimuim requirement.
The
additional_bytesrequested must be at least 10 KiB (MINIMUM_EXTEND_PROGRAM_BYTES), unless the account is smaller thanMAX_PERMITTED_DATA_LEN - MINIMUM_EXTEND_PROGRAM_BYTES, in which caseadditional_bytesmust equal the headroom.