cli: program: remove ExtendProgramChecked#11764
Closed
buffalojoec wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11764 +/- ##
=======================================
Coverage 83.1% 83.1%
=======================================
Files 860 860
Lines 321462 321371 -91
=======================================
- Hits 267408 267347 -61
+ Misses 54054 54024 -30 🚀 New features to boost your workflow:
|
joncinque
reviewed
Apr 9, 2026
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
This is a bit tough, since we don't have any other examples of a CLI command that requires a signer, but the underlying instruction doesn't. We have set-upgrade-authority which defaults to the checked version, and stake-authorize-checked to explicitly perform the check.
The signer check doesn't do much on just the CLI side -- someone could just pass the upgrade authority as a pubkey (null signer) and it would work, for example. For that reason, I would vote to just remove it altogether
Author
Done. |
buffalojoec
force-pushed
the
cli-delete-extend-program-checked
branch
2 times, most recently
from
f4b3263 to
40a913e
Compare
buffalojoec
changed the title
buffalojoec
force-pushed
the
cli-delete-extend-program-checked
branch
from
40a913e to
f05978b
Compare
buffalojoec
force-pushed
the
cli-delete-extend-program-checked
branch
from
f05978b to
a1c8a6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SIMD-0164 was closed and never landed. Therefore the
ExtendProgramCheckedinstruction should not exist.Summary of Changes
Remove it from the CLI.