Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Track Current Channel Size #331

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jun 27, 2024

Description

Adds a metric to kona-derive to track the number of frames in the current (top) channel.

@refcell refcell changed the title feat(derive): track the current channel size feat(derive): Track Current Channel Size Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.7%. Comparing base (f1dedb5) to head (c8cb071).

Files Patch % Lines
crates/derive/src/stages/channel_bank.rs 11.1% 8 Missing ⚠️
crates/derive/src/types/channel.rs 0.0% 6 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell requested a review from clabby June 27, 2024 18:39
@refcell refcell added K-feature Kind: feature A-derive Area: kona-derive crate M-metrics Meta: metric related labels Jun 27, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review June 27, 2024 18:39
@refcell refcell self-assigned this Jun 27, 2024
@refcell refcell force-pushed the refcell/channel-frame-count branch from c8cb071 to f1676a1 Compare June 28, 2024 13:51
@refcell refcell changed the base branch from refcell/metrics-prefix to main June 28, 2024 13:51
@refcell refcell enabled auto-merge June 28, 2024 13:52
@refcell refcell added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit c87fe1d Jun 28, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
@clabby clabby deleted the refcell/channel-frame-count branch July 2, 2024 03:37
This was referenced Jul 8, 2024
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-feature Kind: feature M-metrics Meta: metric related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants